From 550b0d3076eabdc6701870a9e2430d3943d2dae9 Mon Sep 17 00:00:00 2001 From: Sophia Favro Date: Thu, 22 Apr 2021 17:02:13 -0700 Subject: [PATCH 1/3] Added links to best practices page on package upload page --- .../Views/Packages/UploadPackage.cshtml | 24 +++++++------ .../Views/Packages/_VerifyMetadata.cshtml | 34 +++++++++---------- src/NuGetGallery/Web.config | 4 +-- 3 files changed, 33 insertions(+), 29 deletions(-) diff --git a/src/NuGetGallery/Views/Packages/UploadPackage.cshtml b/src/NuGetGallery/Views/Packages/UploadPackage.cshtml index e32d6cbb81..7fac98f09a 100644 --- a/src/NuGetGallery/Views/Packages/UploadPackage.cshtml +++ b/src/NuGetGallery/Views/Packages/UploadPackage.cshtml @@ -17,7 +17,11 @@ @ViewHelpers.AjaxAntiForgeryToken(Html) @ViewHelpers.PackagesBreadcrumb(Url, CurrentUser, true, @Upload)
-

Your package file will be uploaded and hosted on the @(Config.Current.Brand) server (@(Config.Current.SiteRoot)).

+

Your package file will be uploaded and on the @(Config.Current.Brand) server (@(Config.Current.SiteRoot)).

+

+ To learn more about authoring great packages, view our + Best Practices page. +

@@ -52,18 +56,18 @@

- - @if (Model != null && Model.IsUploadInProgress) + @* @if (Model != null && Model.IsUploadInProgress)*@ + @if (true) { -
- @ViewHelpers.AlertInfo(@You had an upload in progress. You can continue it here or cancel to restart.) -
+
+ @ViewHelpers.AlertInfo(@You had an upload in progress. You can continue it here or cancel to restart.) +
} - + @Html.Partial("_VerifyForm") diff --git a/src/NuGetGallery/Views/Packages/_VerifyMetadata.cshtml b/src/NuGetGallery/Views/Packages/_VerifyMetadata.cshtml index b8da379a49..f596224558 100644 --- a/src/NuGetGallery/Views/Packages/_VerifyMetadata.cshtml +++ b/src/NuGetGallery/Views/Packages/_VerifyMetadata.cshtml @@ -60,23 +60,23 @@ @ViewHelpers.AlertWarning( @ - We found the following issue(s): - - We recommend that you fix these issues and upload a new package. - Read more
- ) + We found the following issue(s): + + We recommend that you fix these issues and upload a new package. To learn more about authoring great packages, view our + Best Practices page.
+)
diff --git a/src/NuGetGallery/Web.config b/src/NuGetGallery/Web.config index 6c59822501..635eaad06c 100644 --- a/src/NuGetGallery/Web.config +++ b/src/NuGetGallery/Web.config @@ -321,7 +321,7 @@ --> - + @@ -667,4 +667,4 @@ - + \ No newline at end of file From 2fb4087b636e37579d42f78dad475b548fe8ee88 Mon Sep 17 00:00:00 2001 From: Sophia Favro Date: Fri, 23 Apr 2021 16:02:33 -0700 Subject: [PATCH 2/3] some fixes --- src/NuGetGallery/Views/Packages/UploadPackage.cshtml | 5 ++--- src/NuGetGallery/Web.config | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/NuGetGallery/Views/Packages/UploadPackage.cshtml b/src/NuGetGallery/Views/Packages/UploadPackage.cshtml index 7fac98f09a..08a9844eb8 100644 --- a/src/NuGetGallery/Views/Packages/UploadPackage.cshtml +++ b/src/NuGetGallery/Views/Packages/UploadPackage.cshtml @@ -17,7 +17,7 @@ @ViewHelpers.AjaxAntiForgeryToken(Html) @ViewHelpers.PackagesBreadcrumb(Url, CurrentUser, true, @Upload)
-

Your package file will be uploaded and on the @(Config.Current.Brand) server (@(Config.Current.SiteRoot)).

+

Your package file will be uploaded and on the @(Config.Current.Brand) server (@(Config.Current.SiteRoot)).

To learn more about authoring great packages, view our Best Practices page. @@ -56,8 +56,7 @@

- @* @if (Model != null && Model.IsUploadInProgress)*@ - @if (true) + @if (Model != null && Model.IsUploadInProgress) {
@ViewHelpers.AlertInfo(@You had an upload in progress. You can continue it here or cancel to restart.) diff --git a/src/NuGetGallery/Web.config b/src/NuGetGallery/Web.config index 635eaad06c..c934d4b0d3 100644 --- a/src/NuGetGallery/Web.config +++ b/src/NuGetGallery/Web.config @@ -321,7 +321,7 @@ --> - + From 7d15441607396eb0a4b5b5f977ee643ae0d54ba9 Mon Sep 17 00:00:00 2001 From: Sophia Favro Date: Fri, 23 Apr 2021 16:14:34 -0700 Subject: [PATCH 3/3] fixed more issues --- .../Views/Packages/UploadPackage.cshtml | 9 ++--- .../Views/Packages/_VerifyMetadata.cshtml | 36 +++++++++---------- src/NuGetGallery/Web.config | 2 +- 3 files changed, 24 insertions(+), 23 deletions(-) diff --git a/src/NuGetGallery/Views/Packages/UploadPackage.cshtml b/src/NuGetGallery/Views/Packages/UploadPackage.cshtml index 08a9844eb8..58cce34378 100644 --- a/src/NuGetGallery/Views/Packages/UploadPackage.cshtml +++ b/src/NuGetGallery/Views/Packages/UploadPackage.cshtml @@ -19,7 +19,7 @@

Your package file will be uploaded and on the @(Config.Current.Brand) server (@(Config.Current.SiteRoot)).

- To learn more about authoring great packages, view our + To learn more about authoring great packages, view our Best Practices page.

@@ -56,11 +56,12 @@
+ @if (Model != null && Model.IsUploadInProgress) { -
- @ViewHelpers.AlertInfo(@You had an upload in progress. You can continue it here or cancel to restart.) -
+
+ @ViewHelpers.AlertInfo(@You had an upload in progress. You can continue it here or cancel to restart.) +
}