[README]: Allow media.githubusercontent.com Images in README.md

[RehanSaeed]

Related Problem

I have the following image in my README.md:

This uses the URL:

https://media.githubusercontent.com/media/RehanSaeed/Serilog.Enrichers.Span/main/Images/Banner.png

This shows like this on NuGet:

The Elevator Pitch

Please allow images from media.githubusercontent.com in README.md.

Additional Context and Details

No response

[augustoproiete]

Workaround in the meantime: https://cdn.jsdelivr.net/gh/RehanSaeed/[email protected]/Images/Banner.png

[lyndaidaii]

@augustoproiete, we support list of github related domain below(https://docs.microsoft.com/en-us/nuget/nuget-org/package-readme-on-nuget-org#allowed-domains-for-images-and-badges):
camo.githubusercontent.com
github.com/.../workflows/.../badge.svg
raw.github.com
raw.githubusercontent.com
user-images.githubusercontent.com

The workaround is you could use domain above to render your images.
For the domain, media.githubusercontent.com, we have some security and privacy requirement if we want to add new domain to our allowlist, we will take time to evaluate this domain. We will keep up update once we have a result. Thanks for your patience.

[augustoproiete]

@lyndaidaii Will leave it for @RehanSaeed to decide if he would like to pursue further. I merely suggested a workaround. ☺️

[Xyncgas]

I mean why not just auto accept all request as long these domains are already related to the ones we have.
for example we can confirm when you go to this domain it's part of github

[RehanSaeed]

I tried switching the image to use a direct github URL and that still didn't work.

https://github.com/RehanSaeed/Serilog.Enrichers.Span/blob/main/Images/Banner.png

Please add support for both.

[Giorgi]

In my project the image URL is https://raw.githubusercontent.com/Giorgi/DuckDB.NET/main/Logo.jpg but it is still not displayed on NuGet even though Allowed domains for images and badges contains raw.githubusercontent.com

[lyndaidaii]

@Giorgi I was able to display the image URL you provided on NuGet.org. Please let me know if you have further question.

[Giorgi]

@lyndaidaii

It could be a different issue but I'm not sure. For the logo, Readme.md contains this: ![Project Icon](Logo.jpg "DuckDB.NET Project Icon") This is a relative URL for the image in repo and GitHub understands it and renders it as a picture with domain raw.githubusercontent.com but when I use the same Readme on NuGet I guess NuGet doesn't know how to resolve this relative URL?