Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet.Server update to NuGet.Core 2.14.0 #3219

Closed
emgarten opened this issue Aug 29, 2016 · 7 comments
Closed

NuGet.Server update to NuGet.Core 2.14.0 #3219

emgarten opened this issue Aug 29, 2016 · 7 comments
Assignees

Comments

@emgarten
Copy link
Member

Update NuGet.Server to depend on NuGet.Core 2.14.0

This will provide SemVer 2.0.0 support until #3123 is complete.

I've done some basic testing on this and was able to push and install packages with NuGet.Server after updating NuGet.Core on my own installation.

Related to: NuGet/Home#1359

@justmara
Copy link

justmara commented Aug 31, 2016

SemVer? Really? I just realized that my project based on Nuget.Server is completely broken. It was based on nuget 2.6 and it cannot be updated to 2.10.* because of a total internal redesign in MINOR version. Are you seriously talking about SemVer here?

@emgarten
Copy link
Member Author

@justmara there are no breaking API changes for SemVer in 2.14.0, this issue is to update the package dependency.

2.6 -> 2.10.1 on the other hand looks like +2 years and 11 stable releases of changes.

@maartenba
Copy link
Contributor

@emgarten keep us posted when 2.14.0 drops

@justmara
Copy link

@emgarten SemVer is not about numbers (years or stable releases) but about Versioning and Compatibility. And it strictly declares these three statements:

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards-compatible manner, and
PATCH version when you make backwards-compatible bug fixes.

NuGet.Server fails both first two.

@maartenba
Copy link
Contributor

@justmara That is a different discussion and you are absolutely right. We can't roll-back the current version that is out there, unfortunately, as that would also break projects out there.

@emgarten
Copy link
Member Author

NuGet.Core 2.14.0 is available on nuget.org now. NuGet.Server should be updated to depend on it by default to avoid failures on netstandard/netcoreapp packages.

The current dependency on NuGet.Core 2.11.1 does not contain support for netstandard. This leads to NuGet.Server displaying unsupported as the dependency group TFM which causes the client to select the wrong group, or no dependencies at all.

In the past it has been very hard for users to track down the cause of this problem, so it would be great if we could avoid it by updating NuGet.Server to work out of the box.

//cc @yishaigalatzer @rrelyea

@joelverhagen
Copy link
Member

This is completed in dev and master of NuGet.Server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants