Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Microsoft Account login #253

Closed
ghost opened this issue Nov 18, 2011 · 14 comments
Closed

Support Microsoft Account login #253

ghost opened this issue Nov 18, 2011 · 14 comments
Assignees

Comments

@ghost
Copy link

ghost commented Nov 18, 2011

[Edited by anurse]
Let's add support for Microsoft Account login! From there we can start adding new auth providers.

@phillip-haydon
Copy link

Is the NuGet team open to supporting OAuth for login?

@jeffhandley
Copy link
Member

Yeah, this is starting to get close to the top of the list. This would also alleviate the session timeout issue too #768.

@ghost
Copy link
Author

ghost commented Feb 6, 2013

why is it alleviating the session timeout issue?

@phillip-haydon
Copy link

@dotnetjunky I think because if it signed out and you selected 'Twitter' again, it would re-authenticate and you would be logged in with minimal effort. Rather than having to manually login.

@xavierdecoster
Copy link
Member

I think OAuth makes a lot of sense for the NuGet Gallery. As @dotnetjunky points out, at MyGet we support quite a few using Azure ACS (GitHub, StackOverflow, LiveID, etc), see http://www.myget.org/Account/Login.

image

Bear in mind you'll need some mechanism to link/merge NuGet accounts with these other identities to avoid duplicate accounts being created. Also, first time visitors using OAuth will still need to create a NuGet.org profile (same flow as on MyGet). This to ensure everyone has a username/password for classic authentication, as well as an API key and email address.
Identity providers return different info (LiveID is an annoying one), so you'll have to map this to the claims you want to get from ACS. The beauty of it is that you can manage a lot through ACS afterwards.

@jeffhandley
Copy link
Member

Yeah, we definitely still want to have a NuGet.org "username" but not having an actual password for nuget.org would be grand.

For those of you that have already implemented this in MyGet and JabbR (@PureKrome), we'd really appreciate your help on this.

//cc @anurse @howarddierking

@xavierdecoster
Copy link
Member

Happy to assist, pinging @maartenba as well

@phillip-haydon
Copy link

Awesome sauce, I'm gonna start on this tomorrow night.

@analogrelay
Copy link
Contributor

We'd definitely be open for PRs. Not sure about Azure ACS as it has complexities I'm not sure we want to deal with, but having said that, we also want to consider ADFS log in at some point (specifically for Microsoft's own domain ;)) and ACS might help a lot there.

Just FYI that we're going to need to think and talk about this a bit before we're totally ready, but we'll keep those discussions open and will definitely look at PRs for inspiration if nothing else (and be sure to credit where credit is due :)).

@ghost ghost assigned analogrelay Mar 1, 2013
@analogrelay
Copy link
Contributor

Closing this but we are definitely working on it. See #1348.

@analogrelay
Copy link
Contributor

It's back! We're finally getting rolling on this!

@analogrelay analogrelay reopened this Oct 7, 2013
@PureKrome
Copy link

Andrew - if you're still going to use SimpleAuthentication (now rebranded, was previously known as WorldDom..Authentication) ... then @phillip-haydon and I are here to assist :)

@phillip-haydon - were you going to do a PR for this?

Lastly, this is using Session (until I finish refactoring out Session and replacing it with an ICache - so you can choose your caching mechanism). Is Session an issue, in the very very very short term?

(if no custom ICache will be provided, then it defaults to Session)

@analogrelay
Copy link
Contributor

I'm going to look at a few options. Right now I'm investigating the new Auth components that are part of the Katana Project as they handle Cookie auth, OAuth and will have Federated auth soon. It's less Simple than SimpleAuth though, so we'll see how it goes :).

@PureKrome
Copy link

NP Andrew - I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants