[Final Code, but not ready to merge] Credentials Table #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and to clear out old and busted API key)
| public const string UrlValidationErrorMessage = "This doesn't appear to be a valid HTTP/HTTPS URL"; | ||
| public static class CredentialTypes | ||
| { | ||
| public static readonly string PasswordPbkdf2 = "password.pbkdf2"; |
There was a problem hiding this comment.
The credential type can be any string, but this sets a vague precedent for "[type].[subtype]". For example, if we decided to use a different password hashing algorithm (ROT13, for example), we'd use "password.rot13". Similarly, if we decide to rev API keys to be hashed, we'd use "apikey.v2"
|
Closing this out, opening a new one for the actual merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1389
Adds a Credentials table to store API Keys and Hashed Passwords. Helps prepare for OAuth support next sprint.
Note: This PR should NOT be merged in as it isn't the final merge. I'll be rebasing this on @TimLovellSmith 's sign-up changes and updating it next sprint. There will be a PR there, but I wanted to get this PR out because it's basically all the functional changes, it's just missing the changes necessary to reconcile it with Tim's changes.