Simplify methods in the LockFileUtils, obsolete unused LockFileDependencyProvider #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
changed the title
jeffkl
approved these changes
Dec 16, 2021
Yep. In my earlier refactoring I did break some tests because I was passing a null for the runtimeIdentifier instead of passing it donw. |
nkolev92
deleted the
dev-nkolev92-cleanupLockFileBuildingBySimplifyingSomeMethods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11456
Regression? Last working version:
Description
This is a refactoring that makes the NuGet/Home#5957 changeset a lot smaller.
This change reduces the overexposure of types we have.
It also obsoletes a class that's unused.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation