Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Error on multiple entries for the same package ids in Directory.Packages.props #9467

Closed
cristinamanum opened this issue Apr 22, 2020 · 4 comments
Closed

[Feature] Error on multiple entries for the same package ids in Directory.Packages.props #9467

cristinamanum opened this issue Apr 22, 2020 · 4 comments
Assignees
@jeffkl
Labels
Area:RestoreCPM Central package management Functionality:Restore Type:Feature
Milestone
6.3

Comments

@cristinamanum
Copy link
Contributor

cristinamanum commented Apr 22, 2020 •
edited
Loading

Details about Problem

Error on multiple entries for the same package ids in Directory.Packages.props.

In the current design the first declared entry is honored and the others are ignored.

Note: consider the support for version override. See issue
@cristinamanum cristinamanum added Type:DCR Design Change Request Area:RestoreCPM Central package management labels Apr 22, 2020
@cristinamanum cristinamanum self-assigned this Apr 22, 2020
@cristinamanum cristinamanum added this to the Sprint 173 - 2020.07.24 milestone Jul 2, 2020
@cristinamanum
Copy link
Contributor Author

This issue depends on the #9465. If an error will be raised when there are multiple entries few of the recommended ways to override will start failing.
Re-evaluate this issue after the issue #9465 is fixed.

@nkolev92 nkolev92 added the Priority:2 Issues for the current backlog. label Jul 16, 2020
@cristinamanum cristinamanum removed this from the Sprint 174 - 2020.07.27 milestone Jul 27, 2020
@nkolev92
Copy link
Member

Related to #9864.

I am fixing #9864, which might fix this issue as well.

@jeffkl jeffkl self-assigned this Apr 15, 2022
@jeffkl jeffkl removed the Priority:2 Issues for the current backlog. label Apr 15, 2022
@jeffkl jeffkl mentioned this issue Apr 15, 2022
Closed
7 tasks
@jeffkl jeffkl changed the title [CPVM-OnBoard] Error on multiple entries for the same package ids in Directory.Packages.props [Feature] Error on multiple entries for the same package ids in Directory.Packages.props Apr 15, 2022
@nkolev92
Copy link
Member

In 6.3, NU1506 is raised as a warning when a duplicate is detected.

We can choose to error when we detect duplicates or we can call the warning good and move on to other issues :)

@jeffkl @JonDouglas

@jeffkl jeffkl added this to the Sprint 2022-05 milestone May 2, 2022
@jeffkl
Copy link
Contributor

jeffkl commented May 3, 2022

Thanks @nkolev92, I've verified that your new warning covers this scenario so I'll close this as fixed!

@jeffkl jeffkl closed this as completed May 3, 2022
@nkolev92 nkolev92 modified the milestones: Sprint 2022-05, 6.3 May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffkl jeffkl

Labels
Area:RestoreCPM Central package management Functionality:Restore Type:Feature
Projects
None yet
Milestone
6.3
Development

No branches or pull requests
4 participants
@nkolev92 @cristinamanum @jeffkl @heng-liu