Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content files not added to project (but copied to it) #9094

Closed
davkean opened this issue Jan 24, 2020 · 3 comments
Closed

Content files not added to project (but copied to it) #9094

davkean opened this issue Jan 24, 2020 · 3 comments
Labels
Area:ContentFiles PackageReference contentFiles folder Priority:2 Issues for the current backlog. Resolution:External This issue appears to be External to nuget Style:PackageReference

Comments

@davkean
Copy link

davkean commented Jan 24, 2020

(Moved from: dotnet/project-system#5316 and opened on behalf of @MaceWindu)

Visual Studio Version: 16.2.2

Summary:
Check
OrmTest.csrpoj
project file from this issue. Installing package with content files doesn't work with it properly - files are copied to project folder, but not included into project itself.

I've tried to edit project file by replacing almost everything except project guid with content of new Windows Forms project, but it didn't helped (I suspect it already broke something in solution files at this point).

Steps to Reproduce:

  1. Open attached project

  2. Reinstall linq2db.PostgreSQL nuget package

Expected Behavior:
Content files appeared in project under LinqToDB.Templates folder

Actual Behavior:
Content files appeared in project folder, but not in project

User Impact:
Confusion and anxiety

@nkolev92
Copy link
Member

@MaceWindu

Thanks for filing this issue.

Can you clarify you expectation, how do you expect them to be appear in your projects?
Screenshots would be very helpful!

Thanks.

@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. WaitingForCustomer Applied when a NuGet triage person needs more info from the OP Style:PackageReference labels Jun 11, 2020
@MaceWindu
Copy link

image

  • CoreSDK is .net core console project (SDK project)
  • FwLEgacy is .net framework console project (legacy project format)
  • OrmTest is project from issue

Installing linq2db.postgresql package adds templates (LinqToDB.Templates) to first two project properly (as reference or as copy), but doesn't add anything for OrmTest project

@nkolev92
Copy link
Member

Hey @MaceWindu

So I looked into the repro.
The package in question mark all the packages as BuildAction="None" and CopyToOutput=False.

If you inspect the solution explorer with the new projects, you can see that the content files are wired in.
If you inspect the solution explorer with old PackageReference projects, they are not displayed.

If you change the action to Compile, you will see that both projects fail (cause the files it's linking are not compilable).

As such this is really the same problem as:
dotnet/project-system#3431,
dotnet/project-system#3804 (opened by you :) )
dotnet/project-system#3042

@nkolev92 nkolev92 added Resolution:External This issue appears to be External to nuget and removed Pipeline:New Issues WaitingForCustomer Applied when a NuGet triage person needs more info from the OP labels Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:ContentFiles PackageReference contentFiles folder Priority:2 Issues for the current backlog. Resolution:External This issue appears to be External to nuget Style:PackageReference
Projects
None yet
Development

No branches or pull requests

5 participants