Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a log code NuGetAuditSuppress duplicate items #13620

Closed
nkolev92 opened this issue Jul 12, 2024 · 3 comments · Fixed by NuGet/NuGet.Client#5921
Closed

Add a log code NuGetAuditSuppress duplicate items #13620

nkolev92 opened this issue Jul 12, 2024 · 3 comments · Fixed by NuGet/NuGet.Client#5921
Assignees
@zivkan
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Area:NuGetAudit Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug
Milestone
6.12

Comments

@nkolev92
Copy link
Member

Duplicate item checking is supposed to raise warnings when duplicates are seen.

When NuGetAuditSuppress was added, NU1505 was added as a warning for it.
This should be a new log code.

cc @zivkan
@nkolev92 nkolev92 added Area:ErrorHandling warnings and errors/log messages & related error codes. Functionality:Restore Area:Logging Area:NuGetAudit Priority:1 High priority issues that must be resolved in the current sprint. and removed Area:Logging labels Jul 12, 2024
@nkolev92
Copy link
Member Author

Marking as P1 since we want it done for .NET 9

@zivkan zivkan self-assigned this Jul 14, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

@zivkan Issue is missing Type label, remember to add a Type label

@dotnet-policy-service dotnet-policy-service bot added the missing-required-type The required type label is missing. label Jul 14, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Issue is missing Type label, remember to add a Type label

@dotnet-policy-service dotnet-policy-service bot removed the missing-required-type The required type label is missing. label Jul 14, 2024
This was referenced Jul 14, 2024
Closed
Merged
@zivkan zivkan added this to the 6.12 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zivkan zivkan

Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Area:NuGetAudit Functionality:Restore Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug
Projects
None yet
Milestone
6.12
Development

Successfully merging a pull request may close this issue.

Duplicate NuGetAuditSuppress warnings use code NU1508 NuGet/NuGet.Client
2 participants
@nkolev92 @zivkan