Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support declaring PackageSourceMappings via MSBuild items #12382

Closed
baronfel opened this issue Jan 24, 2023 · 1 comment
Closed

Support declaring PackageSourceMappings via MSBuild items #12382

baronfel opened this issue Jan 24, 2023 · 1 comment
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Partner:MSBuild Type:Feature

Comments

@baronfel
Copy link

NuGet Product(s) Involved

dotnet.exe

The Elevator Pitch

Packages provided directly via the SDK (via the pre-existing LibraryPacks feature or other mechanisms) previously have had some sharp edges with Package Source Mapping and Central Package Version Management. dotnet/sdk#27840 is one example of this, but there have been some enhancements to those mechanisms to automatically filter out certain kinds of packages or package sources (e.g. #11951). This is a great approach, but a future-facing approach might be to allow the SDK to programmatically update Package Source and Mappings for sources and packages that it contributes via adding certain kinds of MSBuild metadata or items - that pushes the work onto the SDK team and relieves the NuGet logic from having to update these distinctions if the desired logic should change at some future time.

Additional Context and Details

No response

@martinrrm martinrrm added Area:PackageSourceMapping Issues related to the package source mapping feature Partner:MSBuild and removed Triage:Untriaged labels Jan 30, 2023
@aortiz-msft
Copy link
Contributor

Dupe of #11731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Partner:MSBuild Type:Feature
Projects
None yet
Development

No branches or pull requests

3 participants