[Bug]: CPVM: Directory.Packages.props Imports aren't being respected

[ransagy]

NuGet Product Used

dotnet.exe, MSBuild.exe

Product Version

dotnet 6.0.1, nuget 6.0.0.280, msbuild 16.11.1+3e40a09f8

Worked before?

No response

Impact

It's more difficult to complete my work

Repro Steps & Context

I have an existing code base that used a combination of Directory.Build.targets files to achieve a pre-cursor to what CPVM does.
The main repo folder has one such file with a bunch of <PackageReference Update="A" Version="1.0.0" /> directives and each solution/project that needs to specialize/override anything has their own copy with an import directive to the baseline file, i.e. <Import Project="../Directory.Build.targets" />.

When migrating that codebase to use CPVM, I followed the same pattern with the Directory.Packages.props files, assuming the Import will apply in the same order and behavior.

This seems to not be the case, As the baseline version of a package "wins" over the nearest version defined in an inner props file.

I've made a simple repro to showcase the issue with Newtonsoft.Json v12 and v13, Where i try to use a type that only exists in the latter in one project.

Expected: The build completes successfully, Meaning the project with the specific Directory.Packages.props with v13 was applied properly.

Actual: The build failes on the missing type, Meaning the baseline v12 was applied.

Steps to repro:

1. Checkout the repo @ https://github.com/ransagy/TestCPVMHierarchy
2. Try to build the repo with dotnet build
3. Note the failure, Remove the Import directive from Console\Directory.Packages.props
4. Build again, This time it passes successfully.

I know there is an open issue on version overriding specifically for CPVM, But i didn't feel this comes from the same source.

There is an msbuild.log file in the repro that is the output of dotnet build in my case as an example.

Verbose Logs

No response

[ransagy]

Pinging @JonDouglas for general awareness as who seems to be leading the CPVM effort lately.

[ransagy]

I forgot to add (or rather, had to rewrite the issue because GitHub erased what I typed because it was too long) - i tried Update instead of Include where applicable and that didn't seem to matter either.

[nkolev92]

@ransagy

You basically have multiple includes, and NuGet will only read the first one, which happens to be the top one.
You're basically hitting #9864.

I'd change the version to PackageVersion Update in the Directory.Packages.Props

Closing this as dup of that.

[ransagy]

You're right; I missed that one, thanks.
One thing to note - it works as long as the nearest props file changes its directives to Update, It fails to build entirely if the baseline props file does. In case someone comes across that.