Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement If-Modified-Since cache for NuGet.Client #11529

Open
erdembayar opened this issue Jan 28, 2022 · 1 comment
Open

Implement If-Modified-Since cache for NuGet.Client #11529

erdembayar opened this issue Jan 28, 2022 · 1 comment
Assignees
@erdembayar
Labels
Area:HttpCaching http caching by all tools Area:Protocol Client/Server protocol /code around it Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug

Comments

@erdembayar
Copy link
Contributor

erdembayar commented Jan 28, 2022 •
edited
Loading

While looking into this performance bug I noticed we're wasting so much time just downloading json and deserializing it. Some of those files are 300-400MB size for MS some internal projects. We need some way to know just content changed or not without having to download whole json response. We can either use If-Modified-Since or Etag cache.

Related issues:
NuGet/NuGetGallery#8048
https://github.com/NuGet/Client.Engineering/issues/1399
#9717

@aortiz-msft @nkolev92
I can come up with mini spec during quality weeks.
@erdembayar erdembayar added Area:HttpCaching http caching by all tools Tenet:Performance Performance issues labels Jan 28, 2022
@erdembayar erdembayar self-assigned this Jan 28, 2022
@nkolev92 nkolev92 added Area:Protocol Client/Server protocol /code around it Functionality:SDK The NuGet client packages published to nuget.org labels Jan 28, 2022
@nkolev92
Copy link
Member

nit: There's already an etags issue, this one could be If-Modified-Since in particular.

@erdembayar erdembayar changed the title Implement If-Modified-Since or Etag cache for NuGet.Client Implement If-Modified-Since cache for NuGet.Client Jan 28, 2022
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. Type:Bug labels Jan 31, 2022
@erdembayar erdembayar mentioned this issue Feb 22, 2022
Merged
8 tasks
@erdembayar erdembayar removed this from the Sprint 2022-03 milestone Mar 7, 2022
@erdembayar erdembayar mentioned this issue Jun 12, 2022
Closed
8 tasks
@erdembayar erdembayar mentioned this issue Jul 6, 2022
Closed
@erdembayar erdembayar mentioned this issue Nov 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erdembayar erdembayar

Labels
Area:HttpCaching http caching by all tools Area:Protocol Client/Server protocol /code around it Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nkolev92 @erdembayar @heng-liu