From 5ff2421f867bb4f6cedecc537303e0688fee7cf0 Mon Sep 17 00:00:00 2001
From: Chen Liangde <chen.liangde@nosto.com>
Date: Mon, 7 Aug 2017 14:43:16 +0300
Subject: [PATCH 1/4] Smarty has been set to secure mode on shopware 5.3.
 Remove the php functions that are not allowed

---
 Views/frontend/plugins/nosto_tagging/checkout/finish.tpl | 2 +-
 Views/frontend/plugins/nosto_tagging/detail/index.tpl    | 4 ++--
 Views/frontend/plugins/nosto_tagging/index.tpl           | 6 +++---
 Views/frontend/plugins/nosto_tagging/listing/index.tpl   | 2 +-
 Views/frontend/plugins/nosto_tagging/search/index.tpl    | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Views/frontend/plugins/nosto_tagging/checkout/finish.tpl b/Views/frontend/plugins/nosto_tagging/checkout/finish.tpl
index 4ffec00f..61bd60b1 100644
--- a/Views/frontend/plugins/nosto_tagging/checkout/finish.tpl
+++ b/Views/frontend/plugins/nosto_tagging/checkout/finish.tpl
@@ -36,7 +36,7 @@
 {block name="frontend_index_content" append}
     <div class="nosto_element" id="thankyou-nosto-1"></div>
     <div class="nosto_element" id="thankyou-nosto-2"></div>
-    {if isset($nostoOrder) && is_object($nostoOrder)}
+    {if isset($nostoOrder) && $nostoOrder}
         <div class="nosto_purchase_order" style="display:none">
             <span class="order_number">{$nostoOrder->getOrderNumber()|escape:'htmlall':'UTF-8'}</span>
             <span class="order_status_code">{$nostoOrder->getOrderStatus()->getCode()|escape:'htmlall':'UTF-8'}</span>
diff --git a/Views/frontend/plugins/nosto_tagging/detail/index.tpl b/Views/frontend/plugins/nosto_tagging/detail/index.tpl
index fa45914c..b28cc3b0 100644
--- a/Views/frontend/plugins/nosto_tagging/detail/index.tpl
+++ b/Views/frontend/plugins/nosto_tagging/detail/index.tpl
@@ -37,7 +37,7 @@
     <div class="nosto_element" id="nosto-page-product1"></div>
     <div class="nosto_element" id="nosto-page-product2"></div>
     <div class="nosto_element" id="nosto-page-product3"></div>
-    {if isset($nostoProduct) && is_object($nostoProduct)}
+    {if isset($nostoProduct) && $nostoProduct}
         <div class="nosto_product" style="display: none">
             <span class="url">{$nostoProduct->getUrl()|escape:'htmlall':'UTF-8'}</span>
             <span class="product_id">{$nostoProduct->getProductId()|escape:'htmlall':'UTF-8'}</span>
@@ -74,7 +74,7 @@
             {/if}
         </div>
     {/if}
-    {if isset($nostoCategory) && is_object($nostoCategory)}
+    {if isset($nostoCategory) && $nostoCategory}
         <div class="nosto_category"
              style="display:none">{$nostoCategory->getCategoryPath()|escape:'htmlall':'UTF-8'}</div>
     {/if}
diff --git a/Views/frontend/plugins/nosto_tagging/index.tpl b/Views/frontend/plugins/nosto_tagging/index.tpl
index 15b74fd3..6c96252b 100644
--- a/Views/frontend/plugins/nosto_tagging/index.tpl
+++ b/Views/frontend/plugins/nosto_tagging/index.tpl
@@ -118,7 +118,7 @@
     {/if}
 {/block}
 {block name="frontend_index_content" append}
-    {if isset($nostoCustomer) && is_object($nostoCustomer)}
+    {if isset($nostoCustomer) && $nostoCustomer}
         <div class="nosto_customer" style="display:none">
             {if isset($nostoHcid) && !empty($nostoHcid)}
                 <span class="hcid">{$nostoHcid|escape:'htmlall':'UTF-8'}</span>
@@ -133,7 +133,7 @@
         {if isset($nostoHcid) && !empty($nostoHcid)}
             <span class="hcid">{$nostoHcid|escape:'htmlall':'UTF-8'}</span>
         {/if}
-        {if isset($nostoCart) && is_object($nostoCart)}
+        {if isset($nostoCart) && $nostoCart}
             {foreach from=$nostoCart->getLineItems() item=lineItem}
                 <div class="line_item">
                     <span class="product_id">{$lineItem->getProductId()|escape:'htmlall':'UTF-8'}</span>
@@ -145,7 +145,7 @@
             {/foreach}
         {/if}
     </div>
-    {if isset($nostoPageType) && is_scalar($nostoPageType)}
+    {if isset($nostoPageType) && is_string($nostoPageType)}
         <div class="nosto_page_type"
              style="display:none">{$nostoPageType|escape:'htmlall':'UTF-8'}</div>
     {/if}
diff --git a/Views/frontend/plugins/nosto_tagging/listing/index.tpl b/Views/frontend/plugins/nosto_tagging/listing/index.tpl
index 46c41b94..c67937fd 100644
--- a/Views/frontend/plugins/nosto_tagging/listing/index.tpl
+++ b/Views/frontend/plugins/nosto_tagging/listing/index.tpl
@@ -36,7 +36,7 @@
 {block name="frontend_index_content" append}
     <div class="nosto_element" id="nosto-page-category1"></div>
     <div class="nosto_element" id="nosto-page-category2"></div>
-    {if isset($nostoCategory) && is_object($nostoCategory)}
+    {if isset($nostoCategory) && $nostoCategory}
         <div class="nosto_category"
              style="display:none">{$nostoCategory->getCategoryPath()|escape:'htmlall':'UTF-8'}</div>
     {/if}
diff --git a/Views/frontend/plugins/nosto_tagging/search/index.tpl b/Views/frontend/plugins/nosto_tagging/search/index.tpl
index ecb41e76..5a24595b 100644
--- a/Views/frontend/plugins/nosto_tagging/search/index.tpl
+++ b/Views/frontend/plugins/nosto_tagging/search/index.tpl
@@ -39,7 +39,7 @@
 
 {block name="frontend_index_content" append}
     <div class="nosto_element" id="nosto-page-search2"></div>
-    {if isset($nostoSearch) && is_object($nostoSearch)}
+    {if isset($nostoSearch) && $nostoSearch}
         <div class="nosto_search_term"
              style="display:none">{$nostoSearch->getSearchTerm()|escape:'htmlall':'UTF-8'}</div>
     {/if}

From c4a1dac70840162031ef17de113a4a9d7db5082c Mon Sep 17 00:00:00 2001
From: Chen Liangde <chen.liangde@nosto.com>
Date: Mon, 14 Aug 2017 11:26:27 +0300
Subject: [PATCH 2/4] =?UTF-8?q?Support=20=E2=80=9Cshow=20review/rating=20c?=
 =?UTF-8?q?reated=20from=20same=20sub=20shop=20only=E2=80=9D=20feature=20i?=
 =?UTF-8?q?ntroduced=20from=20shopware=205.3?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 Bootstrap.php                |  1 +
 Components/Model/Product.php | 27 ++++++++++++++++++++++++---
 2 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/Bootstrap.php b/Bootstrap.php
index e65964c4..3c825fe7 100644
--- a/Bootstrap.php
+++ b/Bootstrap.php
@@ -55,6 +55,7 @@ class Shopware_Plugins_Frontend_NostoTagging_Bootstrap extends Shopware_Componen
     const MENU_PARENT_ID = 23;  // Configuration
     const NEW_ENTITY_MANAGER_VERSION = '5.0.0';
     const NEW_ATTRIBUTE_MANAGER_VERSION = '5.2.0';
+    const SUPPORT_SHOW_REVIEW_SUB_SHOP_ONLY_VERSION = '5.3.0';
     const PLATFORM_UI_VERSION = '1';
     const PAGE_TYPE_FRONT_PAGE = 'front';
     const PAGE_TYPE_CART = 'cart';
diff --git a/Components/Model/Product.php b/Components/Model/Product.php
index 6db3349d..5f28147d 100644
--- a/Components/Model/Product.php
+++ b/Components/Model/Product.php
@@ -40,6 +40,7 @@
 use Shopware_Plugins_Frontend_NostoTagging_Components_Helper_Price as PriceHelper;
 use Shopware_Plugins_Frontend_NostoTagging_Components_Helper_Tag as TagHelper;
 use Shopware_Plugins_Frontend_NostoTagging_Components_Model_Category as NostoCategory;
+use Shopware_Plugins_Frontend_NostoTagging_Bootstrap as NostoBootstrap;
 
 /**
  * Model for product information. This is used when compiling the info about a
@@ -233,6 +234,7 @@ public function loadData(Article $article, Shop $shop = null)
             $shop = Shopware()->Shop();
         }
 
+//        die('aadf');
         try {
             $this->assignId($article);
         } catch (NostoException $e) {
@@ -378,14 +380,33 @@ public function assignId(\Shopware\Models\Article\Article $article)
      */
     protected function amendRatingsAndReviews(Article $article, Shop $shop)
     {
+        //From shopware 5.3, it is possible to display product votes only in sub shop where they posted
+        $showSubshopReivewOnly = false;
+        $showSubshopReivewOnlySupported = version_compare(
+            Shopware::VERSION,
+            NostoBootstrap::SUPPORT_SHOW_REVIEW_SUB_SHOP_ONLY_VERSION,
+            '>='
+        );
+        if ($showSubshopReivewOnlySupported) {
+            $showSubshopReivewOnly = Shopware()->Config()->get('displayOnlySubShopVotes');
+        }
+
         $voteCount = 0;
-        $votes = array();
+        $voteSum = 0;
         foreach ($article->getVotes() as $vote) {
+            if ($showSubshopReivewOnly) {
+                $shopForVote = $vote->getShop();
+                if ($shopForVote !== null
+                    && $shop !== null
+                    && $shopForVote->getId() != $shop->getId()
+                ) {
+                    continue;
+                }
+            }
             ++$voteCount;
-            $votes[] = $vote->getPoints();
+            $voteSum += $vote->getPoints();
         }
         if ($voteCount > 0) {
-            $voteSum = array_sum($votes);
             $voteAvg = round($voteSum / $voteCount, 1);
             $this->setRatingValue($voteAvg);
             $this->setReviewCount($voteCount);

From c10e52b650a745e75a6130b03472a1995dfc0633 Mon Sep 17 00:00:00 2001
From: Chen Liangde <chen.liangde@nosto.com>
Date: Mon, 14 Aug 2017 11:50:18 +0300
Subject: [PATCH 3/4] Fix review comments

---
 Components/Model/Product.php | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/Components/Model/Product.php b/Components/Model/Product.php
index 5f28147d..fcfa6df4 100644
--- a/Components/Model/Product.php
+++ b/Components/Model/Product.php
@@ -36,11 +36,11 @@
 
 use Shopware\Models\Article\Article as Article;
 use Shopware\Models\Shop\Shop as Shop;
+use Shopware_Plugins_Frontend_NostoTagging_Bootstrap as NostoBootstrap;
 use Shopware_Plugins_Frontend_NostoTagging_Components_Helper_Image as ImageHelper;
 use Shopware_Plugins_Frontend_NostoTagging_Components_Helper_Price as PriceHelper;
 use Shopware_Plugins_Frontend_NostoTagging_Components_Helper_Tag as TagHelper;
 use Shopware_Plugins_Frontend_NostoTagging_Components_Model_Category as NostoCategory;
-use Shopware_Plugins_Frontend_NostoTagging_Bootstrap as NostoBootstrap;
 
 /**
  * Model for product information. This is used when compiling the info about a
@@ -234,7 +234,6 @@ public function loadData(Article $article, Shop $shop = null)
             $shop = Shopware()->Shop();
         }
 
-//        die('aadf');
         try {
             $this->assignId($article);
         } catch (NostoException $e) {
@@ -381,20 +380,20 @@ public function assignId(\Shopware\Models\Article\Article $article)
     protected function amendRatingsAndReviews(Article $article, Shop $shop)
     {
         //From shopware 5.3, it is possible to display product votes only in sub shop where they posted
-        $showSubshopReivewOnly = false;
+        $showSubshopReviewOnly = false;
         $showSubshopReivewOnlySupported = version_compare(
             Shopware::VERSION,
             NostoBootstrap::SUPPORT_SHOW_REVIEW_SUB_SHOP_ONLY_VERSION,
             '>='
         );
         if ($showSubshopReivewOnlySupported) {
-            $showSubshopReivewOnly = Shopware()->Config()->get('displayOnlySubShopVotes');
+            $showSubshopReviewOnly = Shopware()->Config()->get('displayOnlySubShopVotes');
         }
 
         $voteCount = 0;
         $voteSum = 0;
         foreach ($article->getVotes() as $vote) {
-            if ($showSubshopReivewOnly) {
+            if ($showSubshopReviewOnly) {
                 $shopForVote = $vote->getShop();
                 if ($shopForVote !== null
                     && $shop !== null

From 546197f8b502fae726e1ccdfb22cdad983a2859d Mon Sep 17 00:00:00 2001
From: Chen Liangde <chen.liangde@nosto.com>
Date: Mon, 14 Aug 2017 14:28:52 +0300
Subject: [PATCH 4/4] Update version number and change log

---
 Bootstrap.php | 2 +-
 CHANGELOG.md  | 6 +++++-
 composer.json | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/Bootstrap.php b/Bootstrap.php
index 3c825fe7..c51a741c 100644
--- a/Bootstrap.php
+++ b/Bootstrap.php
@@ -51,7 +51,7 @@ class Shopware_Plugins_Frontend_NostoTagging_Bootstrap extends Shopware_Componen
 {
 
     const PLATFORM_NAME = 'shopware';
-    const PLUGIN_VERSION = '1.2.4';
+    const PLUGIN_VERSION = '1.2.5';
     const MENU_PARENT_ID = 23;  // Configuration
     const NEW_ENTITY_MANAGER_VERSION = '5.0.0';
     const NEW_ATTRIBUTE_MANAGER_VERSION = '5.2.0';
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0093b942..a420362e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,9 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased][unreleased]
 
+## [1.2.5]
+- Add support for Shopware 5.3
+
 ## [1.2.4]
 - Make order status handling compatible with Shopware < 5.1
 
@@ -139,7 +142,8 @@ recommendations
 - Initial beta-release
 
 
-[unreleased]: https://github.com/nosto/nosto-shopware-plugin/compare/1.2.4...develop
+[unreleased]: https://github.com/nosto/nosto-shopware-plugin/compare/1.2.5...develop
+[1.2.5]: https://github.com/nosto/nosto-shopware-plugin/compare/1.2.4...1.2.5
 [1.2.4]: https://github.com/nosto/nosto-shopware-plugin/compare/1.2.3...1.2.4
 [1.2.3]: https://github.com/nosto/nosto-shopware-plugin/compare/1.2.2...1.2.3
 [1.2.2]: https://github.com/nosto/nosto-shopware-plugin/compare/1.2.1...1.2.2
diff --git a/composer.json b/composer.json
index e362a946..6d12f5b1 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,7 @@
   "license": [
     "BSD-3-Clause"
   ],
-  "version": "1.2.4",
+  "version": "1.2.5",
   "require": {
     "php": ">=5.5.0",
     "nosto/php-sdk": "1.16.3"