Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hardhat-core] Validate network URLs after config resolution #3323

Open
fvictorio opened this issue Nov 2, 2022 · 3 comments
Open

[hardhat-core] Validate network URLs after config resolution #3323

fvictorio opened this issue Nov 2, 2022 · 3 comments
Labels
effort:moderate status:ready This issue is ready to be worked on type:improvement

Comments

@fvictorio
Copy link
Member

fvictorio commented Nov 2, 2022

Our config validation uses the user config, and one of the validations is that all non-Hardhat networks have a URL.

This means that a plugin cannot add its own URL, because by the time the extendConfigs are executed, the user config has been already validated (see for example this)

The resolved config type will still need for the URLs to be mandatory, because we use that in some type guards to distinguish between the Hardhat network and other networks. So we'll probably need to use some dummy values during resolution, and then a post-validation step that checks that no URL has that dummy value.

Needs #3500

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

This issue is also being tracked on Linear.

We use Linear to manage our development process, but we keep the conversations on Github.

LINEAR-ID: 3f1f3cfb-3f09-4461-bbf0-108d21d265f8

@FabijanC
Copy link
Contributor

Is commenting enough to unstale this?

@fvictorio fvictorio added not-stale and removed Stale labels Dec 15, 2022
@fvictorio
Copy link
Member Author

Thanks @FabijanC. I marked this as not stale. We are going to stop using that mechanism soon anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:moderate status:ready This issue is ready to be worked on type:improvement
Projects
Status: No status
Development

No branches or pull requests

2 participants