Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeerDependency issue #429

Closed
xavier-dubruille opened this issue Apr 4, 2021 · 2 comments
Closed

PeerDependency issue #429

xavier-dubruille opened this issue Apr 4, 2021 · 2 comments

Comments

@xavier-dubruille
Copy link

Hello hello,

[email protected] has a peerDependency to [email protected] instead of @7.0.4 !!

Beside not having your last code revision, it also lead to an issue when using current angular version (^11.0.0) and updating with current npm version (7):
because [email protected] wants to install [email protected] which is not compatible (as PeerDependecies) with angular ^11.0.0 ... and make the update fails :/

@xavier-dubruille
Copy link
Author

One way to get around this, is to first update the 'core' package and then update the 'main one' with --legacy-peer-deps

npm update ngx-page-scroll-core
npm update --legacy-peer-deps ngx-page-scroll

Which will put both in version 7.0.4 :)

@Nolanus
Copy link
Owner

Nolanus commented Jun 3, 2021

Sorry for the inconvenience, fixed with v7.0.5

@Nolanus Nolanus closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants