Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserveQueryParams is deprecated #392

Closed
mferak opened this issue Dec 1, 2019 · 0 comments
Closed

preserveQueryParams is deprecated #392

mferak opened this issue Dec 1, 2019 · 0 comments
Labels
bug

Comments

@mferak
Copy link

mferak commented Dec 1, 2019

ngx-page-scroll/projects/ngx-page-scroll/src/lib/ngx-page-scroll.directive.ts

Line 131 in 4fcbe6b

preserveQueryParams: true,

Hi, preserveQueryParams has been deprecated for some time, the correct way is to use queryParamsHandling: 'preserve'. Thanks!

https://angular.io/api/router/NavigationExtras#preserveQueryParams
@Nolanus Nolanus added the bug label Feb 29, 2020
@Nolanus Nolanus closed this as completed in 0ea22b2 Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mferak @Nolanus