-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator duties #570
Validator duties #570
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #570 +/- ##
===========================================
+ Coverage 48.50% 48.79% +0.29%
===========================================
Files 110 117 +7
Lines 1977 2080 +103
Branches 214 225 +11
===========================================
+ Hits 959 1015 +56
- Misses 989 1036 +47
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
src/renderer/constants/dutyStatus.ts
Outdated
@@ -0,0 +1,12 @@ | |||
export enum DutyStatus { | |||
// dont change order of values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assign values mannually pls :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intentionally did that way, without values enum is numerated like an array (but want to keep names for easier readability) and for storing in DB it is more efficient of storing strings and have some logic based on numbers inside put
logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not have
enum DutyStatus {
uknown: "Unknown"
}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum is used for developer-friendly representations of status number
Short description of work done
Implement validator duties screen
PR Checklist
Changes
Issues
Closes #569