-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi client 👨🦯 #565
Multi client 👨🦯 #565
Conversation
# Conflicts: # src/renderer/ducks/beacon/sagas.ts
# Conflicts: # .env.dist # package.json
src/renderer/components/ConfigureBeaconNode/ConfigureBeaconNode.tsx
Outdated
Show resolved
Hide resolved
This pull request introduces 3 alerts when merging cb0eec2 into 1b6ed34 - view on LGTM.com new alerts:
|
src/renderer/services/eth2/client/nimbus/cgNimbusEth2EventsApi.ts
Outdated
Show resolved
Hide resolved
src/renderer/services/eth2/client/prysm/CgPrysmEth2BeaconBlocksApi.ts
Outdated
Show resolved
Hide resolved
// eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
public getFork = async (stateId: "head"): Promise<Fork | null> => { | ||
try { | ||
const forkMock = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should at least load this from some config so that it depends on network
src/renderer/services/eth2/client/prysm/mapProduceBlockDataToPrysmProduceBlock.ts
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #565 +/- ##
===========================================
- Coverage 52.79% 48.50% -4.30%
===========================================
Files 95 110 +15
Lines 1644 1977 +333
Branches 182 214 +32
===========================================
+ Hits 868 959 +91
- Misses 747 989 +242
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
this is kinda big so submitted draft to check if I'm going in a good direction whit it
package.json
scripts (now you can run all-important commands withyarn
)Closes #550
Closes #551