Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something's up with the color? #151

Closed
HeartwawyHorror opened this issue Dec 29, 2019 · 5 comments
Closed

Something's up with the color? #151

HeartwawyHorror opened this issue Dec 29, 2019 · 5 comments

Comments

@HeartwawyHorror
Copy link

HeartwawyHorror commented Dec 29, 2019

image
image
image
Error with loading Cata++ on a new world.

@ephemeralstoryteller
Copy link
Contributor

Confirmed with not only Cata++ but also many mods that add map locations (tested with only Secronom and only Arcana, but no issue with only Magiclysm). Also occurs on loading a game with one of these mods starts throwing these same errors too.

That said, this seems to have been brought about by this change in build 10085. As far as I can tell, this is cosmetic as far as actually playing goes if you hold down spacebar enough.

@ephemeralstoryteller
Copy link
Contributor

ephemeralstoryteller commented Dec 29, 2019

Updates:

First screenshot refers to the fact that "light_brown" (as well as dark_red) is not a color that the game recognizes. I'll correct in a PR shortly!

The second is because this bit is making the game fussy. I'll roll that into the above PR too.

The third one has to do with deprecated suffixes on colors. However, the debug isn't working as intended I don't think, and it's not listing off where exactly the problems are and there's not an easy way to search for these issues that I know of. I'll do my best to weed them out, still.

@ephemeralstoryteller
Copy link
Contributor

All right, should be working smoothly again, as far as I've tested! Figured it all out, I think ^^

@chaosvolt
Copy link
Collaborator

That PR hopefully caught all of them, do report here if something was missed.

@chaosvolt
Copy link
Collaborator

Finally grabbed a build today to test, that covered it just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants