Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Ubuntu 24.04 runner may not have Clippy pre-installed #103

Closed
laniakea64 opened this issue Jul 28, 2024 · 3 comments
Closed

Upcoming Ubuntu 24.04 runner may not have Clippy pre-installed #103

laniakea64 opened this issue Jul 28, 2024 · 3 comments
Labels

Comments

@laniakea64
Copy link
Collaborator

In #78 / 53459ce we removed the "Install Rust Toolchain Components" step, because it's redundant in the current CI runner image. But according to documentation of upcoming Ubuntu 24.04 runner and actions/runner-images#9848 , looks like Clippy will no longer be pre-installed in our CI when that runner image becomes ubuntu-latest. Which actions/runner-images#9848 (comment) suggests will likely happen sometime next month.

We need to either reinstate use of rustup for Clippy or temporarily pin our CI to ubuntu-22.04.

@laniakea64 laniakea64 added the ci label Jul 28, 2024
@laniakea64
Copy link
Collaborator Author

temporarily pin our CI to ubuntu-22.04.

I'm inclined to go this route:

  1. Clippy is far from the only software listed as "Removed from the Ubuntu 24.04 image due to maintenance reasons." With that much software removed for that same reason, it's not immediately clear how many of these removals are expected to be permanent. Maybe wise to delay the switch to Ubuntu 24.04 to see if Clippy might be reinstated later?

  2. Switching on our own schedule means we can be sure to adapt to changes at the time of switching and avoid a period of broken CI.

  3. Ubuntu 22.04 has Vim 8.2.3995 while Ubuntu 24.04 has Vim 9.1.0016. 8.2.3995 is closer to our minimum supported Vim version, so CI having that version makes it more likely to catch issues.

@laniakea64
Copy link
Collaborator Author

Went ahead with pinning CI to ubuntu-22.04 today to get rid of the urgency.

@NoahTheDuke Anything else to consider/address here, or close this?

@laniakea64
Copy link
Collaborator Author

Ubuntu 24.04 has now been ubuntu-latest for some time, and Clippy is still not listed as included.

From https://github.com/actions/runner-images?tab=readme-ov-file#ga -

we only support the latest 2 versions of an OS.

The OS being Ubuntu LTS, Ubuntu 22.04 will be in "latest 2 versions" until sometime in April 2026. I would be inclined to keep CI on Ubuntu 22.04 for now, and deal with longer-term action in early 2026.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant