Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate reconcile_fn from prob_reconcile_fn #91

Open
kdgutier opened this issue Oct 24, 2022 · 0 comments
Open

Separate reconcile_fn from prob_reconcile_fn #91

kdgutier opened this issue Oct 24, 2022 · 0 comments

Comments

@kdgutier
Copy link
Collaborator

Both Bootstrap and Normality probabilistic reconcilers require inputs that depend on a previous run of mean hierarchical reconciliation methods.

Currently the instantiation of probabilistic reconcilers in HierarchicalForecast.reconcile is complicated due to the effort of sending samplers as part of the reconcile_fn arguments.

I believe that separating the responsabilities between reconcile_fn and prob_reconcile_fn, used after the use of the reconcile_fn can improve code's readability and will help to simplify the instantiation of the samplers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants