Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin.deepin-editor: init at 1.2.9.1 #63845

Merged
merged 1 commit into from
Nov 22, 2019
Merged

deepin.deepin-editor: init at 1.2.9.1 #63845

merged 1 commit into from
Nov 22, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 27, 2019

Motivation for this change

Add deepin-editor, a desktop text editor that supports common text editing features.

About packaging deepin for NixOS: #59023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo requested a review from worldofpeace June 27, 2019 03:37
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 27, 2019
@worldofpeace
Copy link
Contributor

So I can never get these applications to draw when installed with nix-env.

Usually get this in the logs

"dtkwidget2" can not find qm files
"deepin-editor" can not find qm files

Seeing that coming from within dtkwidget https://github.com/linuxdeepin/dtkwidget/blob/b1308c8ac3fbf42a1c9204dc07967979bce461cc/src/widgets/dapplication.cpp#L289

So I'm guessing (didn't even read the code) there's some global way of getting translations for each project
that, if not found, doesn't draw the application?

@romildo romildo changed the title deepin.deepin-editor: init at 1.2.9 deepin.deepin-editor: init at 1.2.9.1 Nov 22, 2019
@romildo
Copy link
Contributor Author

romildo commented Nov 22, 2019

So I can never get these applications to draw when installed with nix-env.

It works for me.

@romildo
Copy link
Contributor Author

romildo commented Nov 22, 2019

Usually get this in the logs

"dtkwidget2" can not find qm files
"deepin-editor" can not find qm files

Those messages appear even in deepin linux.

@worldofpeace worldofpeace merged commit 2d67023 into NixOS:master Nov 22, 2019
@romildo romildo deleted the upd.deepin.deepin-editor branch November 22, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romildo @worldofpeace