-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deepin.dde-session-ui: 4.9.11 -> 4.9.12 #63781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears they removed dde-dman-portal
so patching that should be removed and any buildInputs
added for it.
etc/deepin/greeters.d/00-xrandr
Appears to be a bash script.
Maybe should be wrapped with it's runtime deps in PATH?
bin/deepin-greeter
Is a bash script that executes everything in /etc/deepin/greeters.d/
.
And weirdly there's deepin/greeters.d/lightdm-deepin-greeter
there which just executes bin/lightdm-deepin-greeter
Don't know what that's about but it doesn't make any sense to me 🤣
Done.
Replaced
It is not that weird. But |
It appears to be some sort of drop ins system and only used in one other place Don't think it's actually used though so it should be fine to patch it like that. |
Done in previous commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Update to version 4.9.12 - Revise hard coded paths - Wrap binaries in lib/deepin-daemon/
Motivation for this change
lib/deepin-daemon/
About packaging deepin for NixOS: #59023
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)