Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm: 9.14.2 -> 9.14.4 #360139

Merged
merged 1 commit into from
Nov 29, 2024
Merged

pnpm: 9.14.2 -> 9.14.4 #360139

merged 1 commit into from
Nov 29, 2024

Conversation

MisileLab
Copy link
Contributor

https://github.com/pnpm/pnpm/releases/tag/v9.14.3
https://github.com/pnpm/pnpm/releases/tag/v9.14.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: misilelaboratory <[email protected]>
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both PR and upstream changes LGTM.

Running a build right now

@Scrumplex Scrumplex added the backport release-24.11 Backport PR automatically label Nov 29, 2024
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@drupol drupol merged commit b6354e9 into NixOS:master Nov 29, 2024
17 of 18 checks passed
Copy link
Contributor

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-360139-to-release-24.11 origin/release-24.11
cd .worktree/backport-360139-to-release-24.11
git switch --create backport-360139-to-release-24.11
git cherry-pick -x ea0adc05b506daf5986908fde1859eda9d84bbfe

@Scrumplex Scrumplex added backport release-24.11 Backport PR automatically and removed backport release-24.11 Backport PR automatically labels Nov 29, 2024
Copy link
Contributor

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants