Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: pin Gradle 8 where deprecation warning present in build log #359177

Conversation

tomodachi94
Copy link
Member

Some packages have this in their build logs:

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

Let's proactively pin these to Gradle 8 to prevent breakages when Gradle 9 is released, packaged, and set as the default version of gradle.

Package maintainers: I encourage you to submit upstream patches to fix these deprecations, unpinning Gradle 8 once the fix is released by upstream.

This should not cause any rebuilds; please leave a comment if this caused any.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tomodachi94 tomodachi94 requested a review from a team November 26, 2024 03:02
@tomodachi94 tomodachi94 added the 6.topic: java Including JDK, tooling, other languages, other VMs label Nov 26, 2024
Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; untested. Thanks!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2024
@ofborg ofborg bot requested a review from fgaz November 26, 2024 21:59
@tomodachi94 tomodachi94 merged commit 76bb484 into NixOS:master Nov 27, 2024
34 checks passed
@tomodachi94 tomodachi94 deleted the enhance/treewide/pin-gradle-8-where-warning-present branch November 27, 2024 21:45
@tomodachi94 tomodachi94 added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: games 6.topic: java Including JDK, tooling, other languages, other VMs 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants