Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yubikey-manager: 5.4.0 -> 5.5.1 #322907

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

afh
Copy link
Member

@afh afh commented Jun 27, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Lassulus
Copy link
Member

hmm, getting this error when running ykman-gui:

"PyOtherSide error: Traceback (most recent call last):\n\n  File \"<string>\", line 1, in <module>\n\nNameError: name 'yubikey' is not defined\n"
qml: Function not found: 'yubikey.controller.refresh' (Traceback (most recent call last):

  File "<string>", line 1, in <module>

NameError: name 'yubikey' is not defined
)
qml: qrc:/qml/YubiKey.qml:208: TypeError: Cannot read property 'success' of undefined

@afh
Copy link
Member Author

afh commented Jun 27, 2024

Thanks for reporting, @Lassulus. When building yubikey-manager from this branch (nix build .#yubikey-manager) on aarch64-darwin no file named ykman-gui is found in the result/ directory-tree.

Can you provide further info and context for the issue you posted?

  • What command is used to run ykman-gui?
  • Which command was used to install ykman-gui?
  • On which system (version and arch) is ykman-gui run?

@Lassulus
Copy link
Member

ah I ran nixpkgs-review pr 322907, which also builds the packages depending on yubikey-manager, which includes yubikey-manager-qt

@afh
Copy link
Member Author

afh commented Jun 27, 2024

Result of nixpkgs-review pr 322907 run on aarch64-darwin 1

3 packages built:
  • gen-oath-safe
  • yubikey-manager
  • yubikey-manager.dist

I see yubikey-manager-qt meta.platforms is platforms.linux, so it's not run on my aarch64-darwin machine.

@pinpox
Copy link
Member

pinpox commented Jun 28, 2024

Result of nixpkgs-review pr 322907 run on x86_64-linux 1

7 packages built:
  • gen-oath-safe
  • yubikey-manager
  • yubikey-manager-qt
  • yubikey-manager.dist
  • yubioath-flutter
  • yubioath-flutter.debug
  • yubioath-flutter.pubcache

Still get the same error when running as @Lassulus did.

#202295 seems to be related

Also, yubikey-manager-qt seems is unmaintained (see NOTE), maybe we should just drop it?

@afh
Copy link
Member Author

afh commented Jun 28, 2024

Result of nixpkgs-review pr 322907 run on x86_64-linux 1

7 packages built:
  • gen-oath-safe
  • yubikey-manager
  • yubikey-manager-qt
  • yubikey-manager.dist
  • yubioath-flutter
  • yubioath-flutter.debug
  • yubioath-flutter.pubcache

@afh
Copy link
Member Author

afh commented Jun 28, 2024

I'd be in favor of dropping yubikey-manager-qt if yubioath-flutter would build, unfortunately it fails for on both linux and darwin 😒

@afh afh force-pushed the update-yubikey-manager branch from e70425f to 18bbc79 Compare July 2, 2024 20:22
@afh afh changed the title yubikey-manager: 5.4.0 -> 5.5.0 yubikey-manager: 5.4.0 -> 5.5.1 Jul 2, 2024
@Lassulus
Copy link
Member

Lassulus commented Jul 4, 2024

Result of nixpkgs-review pr 322907 run on x86_64-linux 1

7 packages built:
  • gen-oath-safe
  • yubikey-manager
  • yubikey-manager-qt
  • yubikey-manager.dist
  • yubioath-flutter
  • yubioath-flutter.debug
  • yubioath-flutter.pubcache

@Lassulus Lassulus merged commit 10d7234 into NixOS:master Jul 4, 2024
28 checks passed
@Lassulus
Copy link
Member

Lassulus commented Jul 4, 2024

flutter seems to work here, we could mark -qt as broken though

@afh afh deleted the update-yubikey-manager branch July 4, 2024 09:34
@afh
Copy link
Member Author

afh commented Jul 4, 2024

Thanks for testing, reviewing and merging this, @Lassulus, much appreciated 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants