Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netease-cloud-music: init at 1.2.1 #243429

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

netease-cloud-music: init at 1.2.1 #243429

wants to merge 1 commit into from

Conversation

Freed-Wu
Copy link
Contributor

nixos/doc/manual/release-notes/rl-2009.section.md said netease-cloud-music depends on deepin desktop environment and because deepin desktop environment had been removed, netease-cloud-music is also removed.
However, it seems that netease-cloud-music can work without deepin desktop environment. So I package it again.

#94870 removed DDE
NixOS-CN/flakes#51 recommend to push this package to NixOS/nixpkgs

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Freed-Wu
Copy link
Contributor Author

CC: @linyinfeng @romildo @worldofpeace @jtojnar @ttuegel

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 14, 2023
@ofborg ofborg bot requested a review from Ninlives July 14, 2023 08:59
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 14, 2023
@Freed-Wu Freed-Wu force-pushed the netease-cloud-music branch from 8c3c8c4 to 87fea62 Compare July 16, 2023 02:36
@Freed-Wu
Copy link
Contributor Author

Remove some libraries.

@Freed-Wu Freed-Wu force-pushed the netease-cloud-music branch from 87fea62 to 07f0e8a Compare July 17, 2023 05:00
@Freed-Wu
Copy link
Contributor Author

Now, this is result:

$ tree -L 3 result/
 result
├──  bin
│  └──  netease-cloud-music
├──  lib
│  └──  netease-cloud-music
│     ├──  libdouble-conversion.so.1
│     ├──  libjpeg.so.8
│     ├──  libqcef.so.1 -> libqcef.so.1.1.4
│     ├──  libqcef.so.1.1.4
│     ├──  libQt5Core.so.5
│     ├──  libQt5DBus.so.5
│     ├──  libQt5EglFSDeviceIntegration.so.5
│     ├──  libQt5Gui.so.5
│     ├──  libQt5Network.so.5
│     ├──  libQt5Qml.so.5
│     ├──  libQt5Svg.so.5
│     ├──  libQt5WebChannel.so.5
│     ├──  libQt5Widgets.so.5
│     ├──  libQt5X11Extras.so.5
│     ├──  libQt5XcbQpa.so.5
│     ├──  libQt5Xml.so.5
│     ├──  libudev.so.1
│     ├──  libXtst.so.6
│     ├──  plugins
│     └──  qcef
└──  share
   ├──  applications
   │  └──  netease-cloud-music.desktop
   ├──  doc
   │  └──  netease-cloud-music
   └──  icons
      └──  hicolor

Ninlives
Ninlives reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@Ninlives Ninlives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works on my environment, but some tabs fail to load due to network issues, I think these logs are related:

QApplication: invalid style override passed, ignoring it.
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function TLS_client_method
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function SSL_CTX_new
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function OPENSSL_init_ssl
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function ERR_get_error
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function ERR_get_error
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function TLS_client_method
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function SSL_CTX_new
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function OPENSSL_init_ssl
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function ERR_get_error
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function ERR_get_error
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function TLS_client_method
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function SSL_CTX_new
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function OPENSSL_init_ssl
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function ERR_get_error
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function ERR_get_error

I'm actually suprised that main functionalities are still working since the last update was 4 years ago.

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Jul 19, 2023 •
edited
Loading 

QApplication: invalid style override passed, ignoring it.
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function TLS_client_method
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function SSL_CTX_new
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function OPENSSL_init_ssl
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function ERR_get_error
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function ERR_get_error
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function TLS_client_method
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function SSL_CTX_new
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function OPENSSL_init_ssl
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function ERR_get_error
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function ERR_get_error
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function TLS_client_method
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function SSL_CTX_new
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function OPENSSL_init_ssl
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function ERR_get_error
No appenders assotiated with category qt.network.ssl
[Warning] <> QSslSocket: cannot call unresolved function ERR_get_error

I have not met these warnings.

ibus can work for me now.

@Freed-Wu Freed-Wu force-pushed the netease-cloud-music branch from 07f0e8a to af0567b Compare July 19, 2023 16:17
@Freed-Wu
netease-cloud-music: init at 1.2.1
2337d09 
nixos/doc/manual/release-notes/rl-2009.section.md said netease-cloud-music depends on deepin desktop environment and because deepin desktop environment had been removed, netease-cloud-music is also removed.
However, it seems that netease-cloud-music can work without deepin desktop environment. So I package it again.

NixOS#94870 removed DDE
NixOS-CN/flakes#51 recommend to push this package to NixOS/nixpkgs
@Freed-Wu Freed-Wu force-pushed the netease-cloud-music branch from af0567b to 2337d09 Compare July 23, 2023 08:21
@ofborg ofborg bot requested a review from Ninlives July 23, 2023 08:44
@wineee
Copy link
Member

wineee commented Aug 11, 2023

NetEase Cloud Music for Linux is no longer officially maintained, and it has been taken down from the official website (https://music.163.com/#/download).

I suggest pushing it to the Nix User Repository

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 6, 2023
@wegank wegank marked this pull request as draft September 7, 2023 01:09
@Freed-Wu
Copy link
Contributor Author

I suggest pushing it to the Nix User Repository

Yes, before this PR is created, I use it in my NUR.

@Freed-Wu
Copy link
Contributor Author

Any other point about this PR? Now some conflict have been occured 😢

@Aleksanaa
Copy link
Member

wineee is right. Nixpkgs is not the place for dead projects.

@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@Ninlives Ninlives Ninlives approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Freed-Wu @wineee @Aleksanaa @jtojnar @Ninlives @wegank