Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.requests-mock: 1.10.0 -> 1.11.0 #241075

Merged
merged 1 commit into from
Jul 9, 2023
Merged

python310Packages.requests-mock: 1.10.0 -> 1.11.0 #241075

merged 1 commit into from
Jul 9, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Jul 2, 2023

Description of changes

https://github.com/jamielennox/requests-mock/releases/tag/1.11.0

There are a couple of changes that warrant an explanation:

  1. testrepository was removed in Remove testrepository dependency jamielennox/requests-mock#229, so the postPatch hook can be removed.

  2. The mock dependency is no longer needed on Python >= 3.4, so it has been removed.

  3. Tests are now run properly by using pytestCheckHook.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2408

@SuperSandro2000 SuperSandro2000 merged commit 4765199 into NixOS:staging Jul 9, 2023
@tjni tjni deleted the requests-mock branch July 9, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants