-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python310Packages.requests-mock: 1.10.0 -> 1.11.0 #241074
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues with environment.noXLibs
This is not actually a compile time dependency and sharing libs is not worth the it because libva compiles in just a few seconds
this is the new esr release see nss latest updates for changelogs
nss_esr: 3.79.4 -> 3.90
mercurial: 6.4.3 -> 6.4.5
dav1d: 1.2.0 -> 1.2.1
tjni
requested review from
ajs124,
lukegb,
mweinelt,
zowoq,
winterqt,
figsoda,
marsam and
a team
as code owners
July 2, 2023 09:37
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
6.topic: rust
6.topic: ruby
6.topic: vim
6.topic: systemd
labels
Jul 2, 2023
Arghh, how do I keep messing up the rebase. |
How do you rebase? Probably not interactively, or else you would notice this earlier. |
Yeah, I just directly follow the commands from the contributing guide. I had realized I needed to run a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: python
6.topic: ruby
6.topic: rust
6.topic: systemd
6.topic: vim
8.has: module (update)
This PR changes an existing module in `nixos/`
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/jamielennox/requests-mock/releases/tag/1.11.0
There are a couple of changes that warrant an explanation:
testrepository
was removed in Remove testrepository dependency jamielennox/requests-mock#229, so thepostPatch
hook can be removed.The
mock
dependency is no longer needed on Python >= 3.4, so it has been removed.Tests are now run properly by copying what is done in the project's GitHub actions here.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)