Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: use held back patchelf_0_15 to avoid upstream bug #221900

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Mar 18, 2023

patchelf-0.17.2 corrupts $out/bin/emacs binary. It has something to do with program headers change. Let's pin emacs back to 0.15.0 until patchelf is fixed.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

patchelf-0.17.2 corrupts `$out/bin/emacs` binary. It has something to
do with program headers change. Let's pin `emcas` back to `0.15.0`
until `patchelf` is fixed.
Copy link
Member

@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested with:

    emacs = {
      enable = true;
      package = pkgs.emacs28NativeComp;
      extraPackages = epkgs:
        with epkgs; [
          # agda2-mode # Needs to be from same build as agda
          vterm
        ];
    };

on staging-next

@vcunat
Copy link
Member

vcunat commented Mar 19, 2023

It bothers me that the corruption didn't get detected within build of the corrupted package. Therefore we might have more of these cases that don't get detected at Hydra. Well, maybe it's OK-ish uncertainty for nixpkgs master. Either way I hope the bug can be analyzed and fixed quickly upstream.

@vcunat vcunat merged commit ce7e136 into NixOS:staging-next Mar 19, 2023
@trofi trofi deleted the emacs-on-older-patchelf branch March 19, 2023 09:29
vcunat added a commit that referenced this pull request Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants