Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepin.deepin-editor: init at 5.10.35 #213911

Merged
merged 1 commit into from
Feb 3, 2023
Merged

deepin.deepin-editor: init at 5.10.35 #213911

merged 1 commit into from
Feb 3, 2023

Conversation

wineee
Copy link
Member

@wineee wineee commented Feb 1, 2023

Description of changes

martyr-deepin/dde-nixos#9

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@wineee wineee changed the title deepin-editor: init at 5.10.35 deepin.deepin-editor: init at 5.10.35 Feb 1, 2023
@wineee wineee marked this pull request as draft February 1, 2023 06:55
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Feb 1, 2023
@wineee wineee marked this pull request as ready for review February 1, 2023 07:05
@NickCao
Copy link
Member

NickCao commented Feb 3, 2023

Shall we merge this as-is, or wait for the strictDeps fix to land on master?

@wineee
Copy link
Member Author

wineee commented Feb 3, 2023

I tend to merge this as-is, missing qtimageformats only causes a small number of icons cannot be rendered,it's not a major bug as DDE is not fully packaged

@NickCao NickCao merged commit 7e957f0 into NixOS:master Feb 3, 2023
@wineee wineee deleted the deditor branch February 7, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants