-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deepin(library): init at 20.8 #210477
deepin(library): init at 20.8 #210477
Conversation
Result of 2 packages blacklisted:
14 packages built:
|
7c9fad8
to
fb4fa4e
Compare
efd9d17
to
c5a9fd6
Compare
@ofborg build deepin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
pkgs/desktops/deepin/library/deepin-wayland-protocols/default.nix
Outdated
Show resolved
Hide resolved
propagatedBuildInputs = [ | ||
dtkcore | ||
librsvg | ||
qtimageformats | ||
freeimage | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dtkcore
is required in dtkgui.pc
, not sure about the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cannot be added via the qt wrapper or another variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QT_PLUGIN_PATH will be set if qtimageformats in buildInputs
and wrapQtAppsHook in nativeBuildInputs
if dont use propagatedBuildInputs
, we have to set qtimageformats wrapper for all dtk application
, wrapQtAppsHook | ||
, glibmm | ||
, doxygen | ||
, buildDocs ? false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the reason why this is off by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix in #212979
, mtdev | ||
, cairo | ||
, xorg | ||
, waylandSupport ? false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wayland should always be compiled in when possible with x11 at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adaptation of DDE to wanyland is not complete yet,Arch also disables this option : https://github.com/archlinux/svntogit-community/blob/27fead70b2c5388907ce5ac4eeaf413bfc8f7ffd/trunk/PKGBUILD#L25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add a comment explaining this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I remove this option and disable wayland compilation directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, wayland support in deepin may be complete by the end of this year
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
na, then keep it like it is.
Description of changes
I'm trying to port Deepin Desktop Environment to NixOS. Resume work of @romildo and (at)worldofpeace on #94870
I created a flake repository for this work. Porting work nearing completion,I think it's time to request a review.
It will need 70+ commits to add DDE for NixOS, Here is the first part, add all libraries needed for DDE.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes