-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cudaPackages_11_8: init, with support for jetsons #194791
Conversation
defaultBuild = { "tensorrt" = allBuilds.${computeName tensorRTDefaultVersion}; }; | ||
in allBuilds // defaultBuild; | ||
defaultBuildName = computeName tensorRTDefaultVersion; | ||
defaultBuild = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only touching this because of eval errors.
But I'm also really overwhelmed reading this piece
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix seems good to me.
We create an attribute tensorr_${version}
for every available tensorrt
version. Then we add a tensorrt
attribute (so without version, however, for cudatoolklit 11.8 there is no compatible
tensorrt`, and hence we cannot add a default.
In the future we might need a fix like this for the other extensions as well.
also note that there is #194705 open as well |
Ouch, missed it, didn't get a notification. I guess I'll wait for the other PR and then poke the jetson support |
defaultBuildName = computeName tensorRTDefaultVersion; | ||
defaultBuild = | ||
if | ||
builtins.hasAttr defaultBuildName allBuilds then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use the ?
operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought so too, but then I realized I'd have to use it with an interpolation: ? ${defaultBuildName}
. Wasn't sure if that's better than hasAttr
Anyway, @ dguibert handles this differently in # 194705 and I'm yet to have looked at it thoroughly
Description of changes
CUDA 11.8 has been released, this time including redist packages for jetsons.
This PR adds cuda 11.8 redist packages with "x86_64-linux" and "aarch64-linux" platforms.
This also packages cudnn 8.6.0 (x86_64 only), since 8.4.0 doesn't officially support cuda 11.8.
Jetson support is still very limited in that there's still not redist packages for CUDNN on aarch64-linux (-> we cannot build pytorch).
I haven't meaningfully tested jetson support yet.
Things done
nix build --impure .#cudaPackages_11_8.libcublas
on platform(s)Notify maintainers
@NixOS/cuda-maintainers