-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vcsh to 2.x #136720
Update vcsh to 2.x #136720
Conversation
I am very sorry I didn't notice the
Otherwise the vcsh package builds and runs, LGTM. |
Wow what the heck! That should not have gotten in this squash, I was working on that in another branch. I must have gotten sapped by a Neovim buffer still being open and a |
That sile update isn't even current! It was from months ago and is already in master. Another update is in progress in #136453, I've removed that from the commit. |
Co-authored-by: Bobby Rong <[email protected]>
This is rather a shot in the dark. I'm the one that did the work upstream overhauling the build system between 1.x and 2.x so I know what happened there, but I don't know if this packaging is anything like correct.
The major change is that we switched from a home-grown makefile to a regular autotools build with a configure that checks for dependencies and system paths, and a
make install
that puts it all in standardized locations. All standard things like--prefix
when configuring andDESTDIR
when installing should would as expected now.Additionally there are bash and zsh completions that should get installed, but I don't know if this build recipe will handle that or not.
@ttuegel I'm available for questions, and by all means if this doesn't get close feel free to nuke this and handle it however is proper.
Motivation for this change
Upstream release:
https://github.com/RichiH/vcsh/releases/tag/v2.0.1
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)