Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mill: 0.9.8 -> 0.9.9 #130823

Merged
merged 1 commit into from
Jul 20, 2021
Merged

mill: 0.9.8 -> 0.9.9 #130823

merged 1 commit into from
Jul 20, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 20, 2021

Motivation for this change

Use the ${version}-assembly artifact, which avoids
having to download it using the release script

cc @scalavision

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Use the `${version}-assembly` artifact, which avoids
having to download it using the release script
@scalavision
Copy link
Contributor

Thanks Jon! Tested this locally, seems to work really well :-)

@jonringer jonringer merged commit 1916bd8 into NixOS:master Jul 20, 2021
@jonringer jonringer deleted the bump-mill branch July 20, 2021 20:07
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/using-mill-in-sandbox-builds-fails-even-though-it-works-in-pure-shell/11532/10

@github-actions
Copy link
Contributor

Backport failed for release-21.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-21.05
git worktree add -d .worktree/backport-130823-to-release-21.05 origin/release-21.05
cd .worktree/backport-130823-to-release-21.05
git checkout -b backport-130823-to-release-21.05
ancref=$(git merge-base 1b9783191b8f5cef2b8ddcd8d3526a740b19a5f0 74090eb68a2fd8e0a6ef0000f36a784ed2d27194)
git cherry-pick -x $ancref..74090eb68a2fd8e0a6ef0000f36a784ed2d27194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants