Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.httpcore: 0.12.3 -> 0.13.0 #120119

Merged
merged 9 commits into from
May 5, 2021
Merged

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Apr 21, 2021

Motivation for this change

Update to latest upstream release 0.13.0

Change log: https://github.com/encode/httpcore/blob/master/CHANGELOG.md#0130-april-21st-2021

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Apr 21, 2021

httpx update is in progress: encode/httpx#1576

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 27, 2021
@fabaff
Copy link
Member Author

fabaff commented Apr 27, 2021

pytest-httpx needs to be updated: Colin-b/pytest_httpx#40

@fabaff
Copy link
Member Author

fabaff commented Apr 30, 2021

Result of nixpkgs-review pr 120119 run on x86_64-linux 1

9 packages marked as broken and skipped:
  • python38Packages.clifford
  • python38Packages.dask-jobqueue
  • python38Packages.dask-xgboost
  • python38Packages.pytest-sanic
  • python38Packages.rl-coach
  • python39Packages.dask-jobqueue
  • python39Packages.dask-xgboost
  • python39Packages.pytest-sanic
  • python39Packages.rl-coach
40 packages failed to build:
  • home-assistant
  • nixops
  • python38Packages.PyRMVtransport
  • python38Packages.aplpy
  • python38Packages.asdf
  • python38Packages.dask-image
  • python38Packages.entrance
  • python38Packages.entrance-with-router-features
  • python38Packages.fastapi
  • python38Packages.graphene
  • python38Packages.imgaug
  • python38Packages.mask-rcnn
  • python38Packages.pyregion
  • python38Packages.pytest-astropy
  • python38Packages.radio_beam
  • python38Packages.reproject
  • python38Packages.sanic
  • python38Packages.sanic-auth
  • python38Packages.spectral-cube
  • python38Packages.starlette
  • python38Packages.sunpy
  • python39Packages.PyRMVtransport
  • python39Packages.aplpy
  • python39Packages.asdf
  • python39Packages.dask-image
  • python39Packages.entrance
  • python39Packages.entrance-with-router-features
  • python39Packages.fastapi
  • python39Packages.graphene
  • python39Packages.imgaug
  • python39Packages.mask-rcnn
  • python39Packages.pyregion
  • python39Packages.pytest-astropy
  • python39Packages.radio_beam
  • python39Packages.reproject
  • python39Packages.sanic
  • python39Packages.sanic-auth
  • python39Packages.spectral-cube
  • python39Packages.starlette
  • python39Packages.sunpy
136 packages built:
  • azure-cli
  • buku
  • datasette (python38Packages.datasette)
  • flexget
  • http-prompt
  • httpie
  • lexicon
  • nvchecker (python38Packages.nvchecker)
  • papis (python38Packages.papis)
  • python38Packages.WSME
  • python38Packages.aiobotocore
  • python38Packages.aniso8601
  • python38Packages.axis
  • python38Packages.batchgenerators
  • python38Packages.caffe
  • python38Packages.dask
  • python38Packages.dask-gateway
  • python38Packages.dask-glm
  • python38Packages.dask-ml
  • python38Packages.dask-mpi
  • python38Packages.datadog
  • python38Packages.datasets
  • python38Packages.datashader
  • python38Packages.deezer-python
  • python38Packages.distributed
  • python38Packages.duecredit
  • python38Packages.elmax
  • python38Packages.flask-limiter
  • python38Packages.flask-restful
  • python38Packages.flask-restplus
  • python38Packages.flask-restx
  • python38Packages.fsspec
  • python38Packages.gcsfs
  • python38Packages.glymur
  • python38Packages.gradient
  • python38Packages.gradient_statsd
  • python38Packages.habanero
  • python38Packages.httpbin
  • python38Packages.httpcore
  • python38Packages.httpx
  • python38Packages.ihatemoney
  • python38Packages.image-match
  • python38Packages.imagecorruptions
  • python38Packages.intake
  • python38Packages.ipfshttpclient
  • python38Packages.johnnycanencrypt
  • python38Packages.knack
  • python38Packages.pims
  • python38Packages.pubnub
  • python38Packages.pubnubsub-handler
  • python38Packages.pyfftw
  • python38Packages.pylitterbot
  • python38Packages.pytenable
  • python38Packages.pytest-astropy-header
  • python38Packages.pytest-httpbin
  • python38Packages.pytest-httpx
  • python38Packages.pytest-vcr
  • python38Packages.python-awair
  • python38Packages.pywemo
  • python38Packages.qiskit
  • python38Packages.qiskit-ibmq-provider
  • python38Packages.respx
  • python38Packages.restfly
  • python38Packages.s3fs
  • python38Packages.scikitimage
  • python38Packages.slicedimage
  • python38Packages.sparse
  • python38Packages.streamz
  • python38Packages.stumpy
  • python38Packages.stytra
  • python38Packages.tensorly
  • python38Packages.tumpa
  • python38Packages.vcrpy
  • python38Packages.yalexs
  • python39Packages.aiobotocore
  • python39Packages.aniso8601
  • python39Packages.axis
  • python39Packages.batchgenerators
  • python39Packages.caffe
  • python39Packages.dask
  • python39Packages.dask-gateway
  • python39Packages.dask-glm
  • python39Packages.dask-mpi
  • python39Packages.datadog
  • python39Packages.datasets
  • python39Packages.datasette
  • python39Packages.deezer-python
  • python39Packages.distributed
  • python39Packages.duecredit
  • python39Packages.elmax
  • python39Packages.flask-limiter
  • python39Packages.flask-restful
  • python39Packages.flask-restplus
  • python39Packages.flask-restx
  • python39Packages.fsspec
  • python39Packages.gcsfs
  • python39Packages.glymur
  • python39Packages.gradient
  • python39Packages.gradient_statsd
  • python39Packages.habanero
  • python39Packages.httpbin
  • python39Packages.httpcore
  • python39Packages.httpx
  • python39Packages.ihatemoney
  • python39Packages.image-match
  • python39Packages.imagecorruptions
  • python39Packages.intake
  • python39Packages.ipfshttpclient
  • python39Packages.johnnycanencrypt
  • python39Packages.knack
  • python39Packages.nvchecker
  • python39Packages.papis
  • python39Packages.pims
  • python39Packages.pubnub
  • python39Packages.pubnubsub-handler
  • python39Packages.pyfftw
  • python39Packages.pylitterbot
  • python39Packages.pytenable
  • python39Packages.pytest-astropy-header
  • python39Packages.pytest-httpbin
  • python39Packages.pytest-httpx
  • python39Packages.pytest-vcr
  • python39Packages.python-awair
  • python39Packages.pywemo
  • python39Packages.qiskit
  • python39Packages.qiskit-ibmq-provider
  • python39Packages.respx
  • python39Packages.restfly
  • python39Packages.s3fs
  • python39Packages.scikitimage
  • python39Packages.slicedimage
  • python39Packages.streamz
  • python39Packages.tumpa
  • python39Packages.vcrpy
  • python39Packages.yalexs
  • spotdl

@teh
Copy link
Contributor

teh commented Apr 30, 2021

aiobotocore change looks good, thanks!

@mweinelt
Copy link
Member

mweinelt commented May 4, 2021

Breaks the PyRMVTransport tests. I've reported this in the already open issue for httpx==0.18.0 support.

Colin-b/pytest_httpx#40

Required for home-assistant v2021.5.x, maybe. Let's wait and see.

Ultimately an issue with PyRMVTransport, so I contacted the maintainer.

@mweinelt
Copy link
Member

mweinelt commented May 5, 2021

Rebasing on top of latest master and checking out the breakage. I need this change for home-assistant v2021.5.0.

to be continued.

Result of nixpkgs-review pr 120119 run on x86_64-linux 1

9 packages marked as broken and skipped:
  • python38Packages.clifford
  • python38Packages.dask-jobqueue
  • python38Packages.dask-xgboost
  • python38Packages.pytest-sanic
  • python38Packages.rl-coach
  • python39Packages.dask-jobqueue
  • python39Packages.dask-xgboost
  • python39Packages.pytest-sanic
  • python39Packages.rl-coach
64 packages failed to build:
  • dyndnsc
  • home-assistant
  • nixops
  • python38Packages.PyRMVtransport
  • python38Packages.aplpy
  • python38Packages.asdf
  • python38Packages.authcaptureproxy
  • python38Packages.dask-image
  • python38Packages.datashader
  • python38Packages.entrance
  • python38Packages.entrance-with-router-features
  • python38Packages.fastapi
  • python38Packages.imgaug
  • python38Packages.intake
  • python38Packages.json-logging
  • python38Packages.mask-rcnn
  • python38Packages.pyregion
  • python38Packages.pytest-astropy
  • python38Packages.radio_beam
  • python38Packages.reproject
  • python38Packages.sanic
  • python38Packages.sanic-auth
  • python38Packages.sanic-testing
  • python38Packages.spectral-cube
  • python38Packages.starlette
  • python38Packages.sunpy
  • python38Packages.teslajsonpy
  • python39Packages.PyRMVtransport
  • python39Packages.aplpy
  • python39Packages.asdf
  • python39Packages.batchgenerators
  • python39Packages.caffe
  • python39Packages.dask
  • python39Packages.dask-gateway
  • python39Packages.dask-glm
  • python39Packages.dask-image
  • python39Packages.dask-mpi
  • python39Packages.distributed
  • python39Packages.entrance
  • python39Packages.entrance-with-router-features
  • python39Packages.fastapi
  • python39Packages.glymur
  • python39Packages.image-match
  • python39Packages.imagecorruptions
  • python39Packages.imgaug
  • python39Packages.intake
  • python39Packages.json-logging
  • python39Packages.mask-rcnn
  • python39Packages.pims
  • python39Packages.pyfftw
  • python39Packages.pyregion
  • python39Packages.pytest-astropy
  • python39Packages.pytest-astropy-header
  • python39Packages.radio_beam
  • python39Packages.reproject
  • python39Packages.sanic
  • python39Packages.sanic-auth
  • python39Packages.sanic-testing
  • python39Packages.scikitimage
  • python39Packages.slicedimage
  • python39Packages.spectral-cube
  • python39Packages.starlette
  • python39Packages.streamz
  • python39Packages.sunpy
121 packages built:
  • azure-cli
  • buku
  • datasette (python38Packages.datasette)
  • flexget
  • http-prompt
  • httpie
  • lexicon
  • nvchecker (python38Packages.nvchecker)
  • papis (python38Packages.papis)
  • python38Packages.WSME
  • python38Packages.aiobotocore
  • python38Packages.aniso8601
  • python38Packages.axis
  • python38Packages.batchgenerators
  • python38Packages.caffe
  • python38Packages.dask
  • python38Packages.dask-gateway
  • python38Packages.dask-glm
  • python38Packages.dask-ml
  • python38Packages.dask-mpi
  • python38Packages.datadog
  • python38Packages.datasets
  • python38Packages.deezer-python
  • python38Packages.distributed
  • python38Packages.duecredit
  • python38Packages.elmax
  • python38Packages.flask-limiter
  • python38Packages.flask-restful
  • python38Packages.flask-restplus
  • python38Packages.flask-restx
  • python38Packages.fsspec
  • python38Packages.gcsfs
  • python38Packages.glymur
  • python38Packages.gradient
  • python38Packages.gradient_statsd
  • python38Packages.graphene
  • python38Packages.habanero
  • python38Packages.httpbin
  • python38Packages.httpcore
  • python38Packages.httpx
  • python38Packages.ihatemoney
  • python38Packages.image-match
  • python38Packages.imagecorruptions
  • python38Packages.ipfshttpclient
  • python38Packages.johnnycanencrypt
  • python38Packages.knack
  • python38Packages.pims
  • python38Packages.pubnub
  • python38Packages.pubnubsub-handler
  • python38Packages.pyfftw
  • python38Packages.pylitterbot
  • python38Packages.pytenable
  • python38Packages.pytest-astropy-header
  • python38Packages.pytest-httpbin
  • python38Packages.pytest-httpx
  • python38Packages.pytest-vcr
  • python38Packages.python-awair
  • python38Packages.pywemo
  • python38Packages.qiskit
  • python38Packages.qiskit-ibmq-provider
  • python38Packages.respx
  • python38Packages.restfly
  • python38Packages.s3fs
  • python38Packages.scikitimage
  • python38Packages.slicedimage
  • python38Packages.sparse
  • python38Packages.streamz
  • python38Packages.stumpy
  • python38Packages.stytra
  • python38Packages.tensorly
  • python38Packages.tumpa
  • python38Packages.vcrpy
  • python38Packages.yalexs
  • python39Packages.aiobotocore
  • python39Packages.aniso8601
  • python39Packages.authcaptureproxy
  • python39Packages.axis
  • python39Packages.datadog
  • python39Packages.datasets
  • python39Packages.datasette
  • python39Packages.deezer-python
  • python39Packages.duecredit
  • python39Packages.elmax
  • python39Packages.flask-limiter
  • python39Packages.flask-restful
  • python39Packages.flask-restplus
  • python39Packages.flask-restx
  • python39Packages.fsspec
  • python39Packages.gcsfs
  • python39Packages.gradient
  • python39Packages.gradient_statsd
  • python39Packages.graphene
  • python39Packages.habanero
  • python39Packages.httpbin
  • python39Packages.httpcore
  • python39Packages.httpx
  • python39Packages.ihatemoney
  • python39Packages.ipfshttpclient
  • python39Packages.johnnycanencrypt
  • python39Packages.knack
  • python39Packages.nvchecker
  • python39Packages.papis
  • python39Packages.pubnub
  • python39Packages.pubnubsub-handler
  • python39Packages.pylitterbot
  • python39Packages.pytenable
  • python39Packages.pytest-httpbin
  • python39Packages.pytest-httpx
  • python39Packages.pytest-vcr
  • python39Packages.python-awair
  • python39Packages.pywemo
  • python39Packages.qiskit
  • python39Packages.qiskit-ibmq-provider
  • python39Packages.respx
  • python39Packages.restfly
  • python39Packages.s3fs
  • python39Packages.teslajsonpy
  • python39Packages.tumpa
  • python39Packages.vcrpy
  • python39Packages.yalexs
  • spotdl

@mweinelt mweinelt self-assigned this May 5, 2021
@ofborg ofborg bot requested a review from AluisioASG May 5, 2021 21:01
@mweinelt
Copy link
Member

mweinelt commented May 5, 2021

Sanic was the only build failure due to the httpx or httpcore update, most other are unrelated or flaky.

9 packages marked as broken and skipped:
  • python38Packages.clifford
  • python38Packages.dask-jobqueue
  • python38Packages.dask-xgboost
  • python38Packages.pytest-sanic
  • python38Packages.rl-coach
  • python39Packages.dask-jobqueue
  • python39Packages.dask-xgboost
  • python39Packages.pytest-sanic
  • python39Packages.rl-coach
21 packages failed to build:
  • home-assistant
  • nixops
  • python38Packages.PyRMVtransport
  • python38Packages.dask-image
  • python38Packages.datashader
  • python38Packages.fastapi
  • python38Packages.imgaug
  • python38Packages.mask-rcnn
  • python38Packages.starlette
  • python39Packages.PyRMVtransport
  • python39Packages.dask-image
  • python39Packages.entrance
  • python39Packages.entrance-with-router-features
  • python39Packages.fastapi
  • python39Packages.imgaug
  • python39Packages.json-logging
  • python39Packages.mask-rcnn
  • python39Packages.sanic
  • python39Packages.sanic-auth
  • python39Packages.sanic-testing
  • python39Packages.starlette
162 packages built:
  • azure-cli
  • buku
  • datasette (python38Packages.datasette)
  • dyndnsc
  • flexget
  • http-prompt
  • httpie
  • lexicon
  • nvchecker (python38Packages.nvchecker)
  • papis (python38Packages.papis)
  • python38Packages.WSME
  • python38Packages.aiobotocore
  • python38Packages.aniso8601
  • python38Packages.aplpy
  • python38Packages.asdf
  • python38Packages.authcaptureproxy
  • python38Packages.axis
  • python38Packages.batchgenerators
  • python38Packages.caffe
  • python38Packages.dask
  • python38Packages.dask-gateway
  • python38Packages.dask-glm
  • python38Packages.dask-ml
  • python38Packages.dask-mpi
  • python38Packages.datadog
  • python38Packages.datasets
  • python38Packages.deezer-python
  • python38Packages.distributed
  • python38Packages.duecredit
  • python38Packages.elmax
  • python38Packages.entrance
  • python38Packages.entrance-with-router-features
  • python38Packages.flask-limiter
  • python38Packages.flask-restful
  • python38Packages.flask-restplus
  • python38Packages.flask-restx
  • python38Packages.fsspec
  • python38Packages.gcsfs
  • python38Packages.glymur
  • python38Packages.gradient
  • python38Packages.gradient_statsd
  • python38Packages.graphene
  • python38Packages.habanero
  • python38Packages.httpbin
  • python38Packages.httpcore
  • python38Packages.httpx
  • python38Packages.ihatemoney
  • python38Packages.image-match
  • python38Packages.imagecorruptions
  • python38Packages.intake
  • python38Packages.ipfshttpclient
  • python38Packages.johnnycanencrypt
  • python38Packages.json-logging
  • python38Packages.knack
  • python38Packages.pims
  • python38Packages.pubnub
  • python38Packages.pubnubsub-handler
  • python38Packages.pyfftw
  • python38Packages.pylitterbot
  • python38Packages.pyregion
  • python38Packages.pytenable
  • python38Packages.pytest-astropy
  • python38Packages.pytest-astropy-header
  • python38Packages.pytest-httpbin
  • python38Packages.pytest-httpx
  • python38Packages.pytest-vcr
  • python38Packages.python-awair
  • python38Packages.pywemo
  • python38Packages.qiskit
  • python38Packages.qiskit-ibmq-provider
  • python38Packages.reproject
  • python38Packages.respx
  • python38Packages.restfly
  • python38Packages.s3fs
  • python38Packages.sanic
  • python38Packages.sanic-auth
  • python38Packages.sanic-testing
  • python38Packages.scikitimage
  • python38Packages.slicedimage
  • python38Packages.sparse
  • python38Packages.spectral-cube
  • python38Packages.streamz
  • python38Packages.stumpy
  • python38Packages.stytra
  • python38Packages.sunpy
  • python38Packages.tensorly
  • python38Packages.teslajsonpy
  • python38Packages.tumpa
  • python38Packages.vcrpy
  • python38Packages.yalexs
  • python39Packages.aiobotocore
  • python39Packages.aniso8601
  • python39Packages.aplpy
  • python39Packages.asdf
  • python39Packages.authcaptureproxy
  • python39Packages.axis
  • python39Packages.batchgenerators
  • python39Packages.caffe
  • python39Packages.dask
  • python39Packages.dask-gateway
  • python39Packages.dask-glm
  • python39Packages.dask-mpi
  • python39Packages.datadog
  • python39Packages.datasets
  • python39Packages.datasette
  • python39Packages.deezer-python
  • python39Packages.distributed
  • python39Packages.duecredit
  • python39Packages.elmax
  • python39Packages.flask-limiter
  • python39Packages.flask-restful
  • python39Packages.flask-restplus
  • python39Packages.flask-restx
  • python39Packages.fsspec
  • python39Packages.gcsfs
  • python39Packages.glymur
  • python39Packages.gradient
  • python39Packages.gradient_statsd
  • python39Packages.graphene
  • python39Packages.habanero
  • python39Packages.httpbin
  • python39Packages.httpcore
  • python39Packages.httpx
  • python39Packages.ihatemoney
  • python39Packages.image-match
  • python39Packages.imagecorruptions
  • python39Packages.intake
  • python39Packages.ipfshttpclient
  • python39Packages.johnnycanencrypt
  • python39Packages.knack
  • python39Packages.nvchecker
  • python39Packages.papis
  • python39Packages.pims
  • python39Packages.pubnub
  • python39Packages.pubnubsub-handler
  • python39Packages.pyfftw
  • python39Packages.pylitterbot
  • python39Packages.pyregion
  • python39Packages.pytenable
  • python39Packages.pytest-astropy
  • python39Packages.pytest-astropy-header
  • python39Packages.pytest-httpbin
  • python39Packages.pytest-httpx
  • python39Packages.pytest-vcr
  • python39Packages.python-awair
  • python39Packages.pywemo
  • python39Packages.qiskit
  • python39Packages.qiskit-ibmq-provider
  • python39Packages.reproject
  • python39Packages.respx
  • python39Packages.restfly
  • python39Packages.s3fs
  • python39Packages.scikitimage
  • python39Packages.slicedimage
  • python39Packages.spectral-cube
  • python39Packages.streamz
  • python39Packages.sunpy
  • python39Packages.teslajsonpy
  • python39Packages.tumpa
  • python39Packages.vcrpy
  • python39Packages.yalexs
  • spotdl

@mweinelt mweinelt marked this pull request as ready for review May 5, 2021 21:02
@mweinelt mweinelt merged commit fe7f0e8 into NixOS:master May 5, 2021
@fabaff fabaff deleted the bump-httpcore branch May 5, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants