Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "google-play-music-desktop-player: drop" #115907

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Revert "google-play-music-desktop-player: drop" #115907

merged 3 commits into from
Mar 12, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

The package is still useful for YouTube Music.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Revert "google-play-music-desktop-player: drop"
4770987 
This reverts commit aef2a70.
The package is still useful for YouTube Music.
@dotlambda dotlambda requested a review from anna328p March 11, 2021 08:33
@dotlambda dotlambda mentioned this pull request Mar 11, 2021
Merged
10 tasks
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 11, 2021
@ofborg ofborg bot requested a review from SuprDewd March 11, 2021 08:42
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 11, 2021
@dotlambda
Copy link
Member Author

@anna328p Would you like to be one of the maintainers for this package?

@anna328p
Copy link
Member

@anna328p Would you like to be one of the maintainers for this package?

Yes, I could do this. I already maintain an overlay for it.

anna328p
anna328p approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@anna328p anna328p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotlambda dotlambda merged commit abdf8a2 into NixOS:master Mar 12, 2021
@dotlambda dotlambda deleted the google-play-music-desktop-player-reinit branch March 12, 2021 12:28
@klemensn klemensn mentioned this pull request Jun 16, 2022
Merged
klemensn added a commit to klemensn/nixpkgs that referenced this pull request Jun 16, 2022
@klemensn
google-play-music-desktop-player: Remove
f4a6eb9 
`meta.homepage` is unreachable and starting GPMDP eventually just shows
a black screen as described in

MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-#3942

It also depends on deprecated GNOME2/GTK2.

Google Play Music has been discontinued but this program also supported
YouTube Music, for which also `pkgs.ytmdesktop` exists.

See NixOS#39976.
See NixOS#115239.
See NixOS#115907.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@anna328p anna328p anna328p approved these changes

@SuprDewd SuprDewd Awaiting requested review from SuprDewd

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotlambda @anna328p @SuperSandro2000