Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tintin failing to build on darwin #90273

Closed
abathur opened this issue Jun 14, 2020 · 3 comments · Fixed by #135525
Closed

tintin failing to build on darwin #90273

abathur opened this issue Jun 14, 2020 · 3 comments · Fixed by #135525
Labels
0.kind: bug Something is broken 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin

Comments

@abathur
Copy link
Member

abathur commented Jun 14, 2020

Describe the bug
Tintin started failing to build on macOS at the end of January. I see the same failures local as appear in hydra. The errors look like:

Undefined symbols for architecture x86_64:
  "_fmemopen", referenced from:
      _class_load in class.o
  "_open_memstream", referenced from:
      _class_save in class.o
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:76: tt++] Error 1
builder for '/nix/store/h4lib9n0zhsd99yaba0i0djixxhn76vj-tintin-2.02.01.drv' failed with exit code 2
error: build of '/nix/store/h4lib9n0zhsd99yaba0i0djixxhn76vj-tintin-2.02.01.drv' failed

I've tried to do as much legwork as I can, but I don't understand the details well enough to have any sense of what the resolution may be.

  1. Here's the last successful check on a version-bump PR, and the first failed check on a version bump PR.

  2. It looks like the build started breaking after an update to tintin introduced calls to open_memstream and fmemopen, which I gather historically didn't exist in libc on macOS (but it sounds like they've been present since 10.13). Here's a link to the diff adding each to tintin:

  3. I can't swear it's up-to-date, but here are the macOS installation instructions from the official site in case they're meaningful: https://tintin.mudhalla.net/install.php#OSX

Notify maintainers
Pinging a few people I've seen dealing with compilation on Darwin. @matthewbauer @LnL7 @vcunat @veprbl @FRidh

@abathur abathur added the 0.kind: bug Something is broken label Jun 14, 2020
@veprbl veprbl added the 6.topic: darwin Running or building packages on Darwin label Jun 14, 2020
@abathur
Copy link
Member Author

abathur commented Jun 24, 2020

Many thanks to @alyssais for spotting the obvious, here; it looks like this is about the apple sdk still being at 10.12, while these symbols were introduced in 10.13.

There was an attempt to update in #73744 spurred by the 10.12 URL changing but called off once a new source was found for 10.12

@veprbl
Copy link
Member

veprbl commented Oct 23, 2020

From what I can tell the _open_memstream is available in libsystem_c only starting macOS 10.14.

Perhaps tintin can be patched to work with some independent implementations

@stale
Copy link

stale bot commented Jun 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants