Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream tmpfiles.d #40594

Closed
jtojnar opened this issue May 16, 2018 · 4 comments
Closed

Use upstream tmpfiles.d #40594

jtojnar opened this issue May 16, 2018 · 4 comments
Labels
0.kind: enhancement Add something new 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
Milestone

Comments

@jtojnar
Copy link
Member

jtojnar commented May 16, 2018

Currently, NixOS modules define tmpfiles.d manually using systemd.tmpfiles.rules option. Many packages provide the configuration files, though, so it would make sense to reuse them.

The easiest method would be manually adding the files to /etc, e.g. environment.etc."tmpfiles.d/rkt.conf".source = "${pkgs.rkt}/lib/tmpfiles.d/rkt.conf";, but automating it the same way services are installed would probably make more sense in the long term. systemd.packages could recognize at least ${pkg}/etc/tmpfiles.d/*.conf and ${pkg}/lib/tmpfiles.d/*.conf files, see tmpfiles.d(5), and install them to /etc automatically.

@jtojnar jtojnar added 0.kind: enhancement Add something new 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels May 16, 2018
@flokli
Copy link
Contributor

flokli commented Oct 4, 2019

I agree this should be done in systemd.packages - we recently (#65376) moved support for generators into systemd.packages too.

We might also want to add example/tmpfiles.d to the list of paths (#69295), or move the systemd tmpfiles to an appropriate location during install.

possible usages: #66856

@flokli flokli added this to the 20.03 milestone Oct 4, 2019
@disassembler disassembler modified the milestones: 20.03, 20.09 Feb 5, 2020
@stale
Copy link

stale bot commented Aug 4, 2020

Hello, I'm a bot and I thank you in the name of the community for opening this issue.

To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it.

If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use Git blame or GitHub's web interface on the relevant files to find them.

Lastly, you can always ask for help at our Discourse Forum or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 4, 2020
@flokli
Copy link
Contributor

flokli commented Aug 15, 2020

I think this has been implemented with #93073, hasn't it?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 15, 2020
@Mic92
Copy link
Member

Mic92 commented Aug 16, 2020

yes.

@Mic92 Mic92 closed this as completed Aug 16, 2020
@JohnRTitor JohnRTitor moved this to Done in systemd Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
Projects
Status: Done
Development

No branches or pull requests

4 participants