python: stop using package parameters to control build options

[Pandapip1]

Issue description

The python package currently uses non-standard parameters to control build options. However, a number of these have actually become standard nix environment variables that should be looked up at build time. Specifically:

• nixpkgs/pkgs/development/interpreters/python/cpython/default.nix

  Lines 75 to 76 in cea28c8

  	# enable asserts to ensure the build remains reproducible
  	, reproducibleBuild ? false

  corresponds to the environment variable NIX_ENFORCE_PURITY

• nixpkgs/pkgs/development/interpreters/python/cpython/default.nix

  Lines 65 to 67 in cea28c8

  	# pgo (not reproducible) + -fno-semantic-interposition
  	# https://docs.python.org/3/using/configure.html#cmdoption-enable-optimizations
  	, enableOptimizations ? false

  corresponds to the (inverse of the) environment variable NIX_ENFORCE_NO_NATIVE

Additionally:

• nixpkgs/pkgs/development/interpreters/python/cpython/default.nix

  Lines 69 to 70 in cea28c8

  	# improves performance, but remains reproducible
  	, enableNoSemanticInterposition ? true

  appears to have no more reason to exist, and

• nixpkgs/pkgs/development/interpreters/python/cpython/default.nix

  Lines 72 to 73 in cea28c8

  	# enabling LTO on 32bit arch causes downstream packages to fail when linking
  	, enableLTO ? stdenv.hostPlatform.isDarwin || (stdenv.hostPlatform.is64bit && stdenv.hostPlatform.isLinux)

  should probably be in a let, as I can't see a good reason to want to manually disable it.

• nixpkgs/pkgs/development/interpreters/python/cpython/default.nix

  Line 60 in cea28c8

  , static ? stdenv.hostPlatform.isStatic

  should be replaced by finalAttrs.stdenv.hostPlatform.isStatic

Notify maintainers

@mweinelt @natsukium

---

Note for maintainers: Please tag this issue in your PR.

---

Add a 👍 reaction to issues you find important.