Build failure: mozillavpn

[devurandom]

Steps To Reproduce

Steps to reproduce the behavior:

1. inputs.nixpkgs.url = flake:nixpkgs/nixos-unstable;
2. services.mozillavpn.enable = true;
3. sudo nixos-rebuild dry-activate

Build log

In file included from /build/source/src/platforms/linux/daemon/dnsutilslinux.h:12,
                 from /build/source/src/platforms/linux/daemon/dbusservice.h:13,
                 from /build/source/src/platforms/linux/daemon/dbusservice.cpp:5:
/build/source/src/platforms/linux/daemon/dbustypeslinux.h: In function 'const QDBusArgument& operator>>(const QDBusArgument&, DnsResolver&)':
/build/source/src/platforms/linux/daemon/dbustypeslinux.h:49:26: error: 'qsizetype QByteArray::count() const' is deprecated: Use size() or length() instead. [-Werror=deprecated-declarations]
   49 |     } else if (data.count() >= 4) {
      |                ~~~~~~~~~~^~
In file included from /nix/store/bgfalfi93kbn8j1wfwz0x0dnk1wx9wdp-qtbase-6.8.0/include/QtCore/qmetatype.h:11,
                 from /nix/store/bgfalfi93kbn8j1wfwz0x0dnk1wx9wdp-qtbase-6.8.0/include/QtDBus/qtdbusglobal.h:8,
                 from /nix/store/bgfalfi93kbn8j1wfwz0x0dnk1wx9wdp-qtbase-6.8.0/include/QtDBus/qdbuscontext.h:7,
                 from /nix/store/bgfalfi93kbn8j1wfwz0x0dnk1wx9wdp-qtbase-6.8.0/include/QtDBus/QDBusContext:1,
                 from /build/source/src/platforms/linux/daemon/dbusservice.h:8:
/nix/store/bgfalfi93kbn8j1wfwz0x0dnk1wx9wdp-qtbase-6.8.0/include/QtCore/qbytearray.h:501:22: note: declared here
  501 |     inline qsizetype count() const noexcept { return size(); }
      |                      ^~~~~

Full logs: https://gist.github.com/devurandom/9b6d29eb81dabb7de6ad8f4a02a2c69b

Additional context

My flake.lock:

{
  "nodes": {
    "home-manager": {
      "inputs": {
        "nixpkgs": [
          "nixpkgs"
        ]
      },
      "locked": {
        "lastModified": 1729260213,
        "narHash": "sha256-jAvHoU/1y/yCuXzr2fNF+q6uKmr8Jj2xgAisK4QB9to=",
        "owner": "nix-community",
        "repo": "home-manager",
        "rev": "09a0c0c02953318bf94425738c7061ffdc4cba75",
        "type": "github"
      },
      "original": {
        "id": "home-manager",
        "type": "indirect"
      }
    },
    "nixpkgs": {
      "locked": {
        "lastModified": 1729070438,
        "narHash": "sha256-KOTTUfPkugH52avUvXGxvWy8ibKKj4genodIYUED+Kc=",
        "owner": "NixOS",
        "repo": "nixpkgs",
        "rev": "5785b6bb5eaae44e627d541023034e1601455827",
        "type": "github"
      },
      "original": {
        "id": "nixpkgs",
        "ref": "nixos-unstable",
        "type": "indirect"
      }
    },
    "root": {
      "inputs": {
        "home-manager": "home-manager",
        "nixpkgs": "nixpkgs"
      }
    }
  },
  "root": "root",
  "version": 7
}

Notify maintainers

@andersk

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

❯ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.11.1, NixOS, 24.11 (Vicuna), 24.11.20241004.bc947f5`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.8`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/store/sdzpqjwx7pdx6lsq6llyfqqf7hspp83c-source`

---

Add a 👍 reaction to issues you find important.

[andersk]

Known:

• mozillavpn: Fix build errors from Qt deprecations #348915

[Elias-Graf]

Hey, quick question if you have the time. I've tried applying the modified file from your PR as an overlay.

I've put the following in my flake.nix for the sytem packages:

        perseus = nixpkgs.lib.nixosSystem {
          specialArgs = { inherit home-manager; };

          modules = [
            {
              nixpkgs.overlays = [
                (self: super: {
                  mozillavpn = super.callPackage ./overlays/mozillavpn.nix { };
                })
              ];
            }

and this in my home manager configuration:

  home-manager.users.elias = { pkgs, ... }: {
    home = {
      stateVersion = "23.05";
      username = "elias";
      homeDirectory = "/home/elias";

    };

    nixpkgs = {
      overlays = [
        (self: super: {
          mozillavpn = super.callPackage ../../overlays/mozillavpn.nix { };
        })
      ];
    };

And while my system builds again, if I try to run the vpn, I get: [1] 32396 segmentation fault (core dumped) mozillavpn. So I've probably done something incorrectly.

I was actually quite surprised, when initially just putting the overlay in home-manager wasn't enough, since that's the only place I use the package mozillavpn, but then I suspect that the service services.mozillavpn.enable = true; has something to do with it, so I also placed it in the system overlays. But that might have broken something?

[andersk]

@Elias-Graf The segfault is addressed by

• mozillavpn: Fix segfault on startup with Qt 6.8 #351033