Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.torchWithRocm: 2.0.0 unnecessarily requires unfree dependencies #224689

Closed
SomeoneSerge opened this issue Apr 4, 2023 · 2 comments

Comments

@SomeoneSerge
Copy link
Contributor

SomeoneSerge commented Apr 4, 2023

Issue description

Once we update python3Packages.torch to 2.X.X, its torchWithRocm variation will depend on cudaPacakges.cuda_nvcc (through python3Packages.openai-triton), which is unfree. This means hydra won't be building and caching torchWithRocm.

Upstream enforces that there be a copy of bin/ptxas (from cuda_nvcc):

However, they do not actually use it except for cuda support (obviosuly).
We should patch around this to re-enable caching, and we should work with upstream to make the dependency optional in the first place

CC @NixOS/rocm-maintainers

@Madouura
Copy link
Contributor

Sadly, with the new ROCm updates, I've only made it worse.
We can't seem to reasonably patch hsa-amd-aqlprofile out of rocprofiler anymore.

@Madouura
Copy link
Contributor

This was fixed in 6f3f5b6 and #263048.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants