Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove types.string #16750

Open
Profpatsch opened this issue Jul 6, 2016 · 8 comments
Open

Remove types.string #16750

Profpatsch opened this issue Jul 6, 2016 · 8 comments
Labels
0.kind: enhancement Add something new 6.topic: module system About "NixOS" module system internals 9.needs: clean-up

Comments

@Profpatsch
Copy link
Member

types.string has been deprecated for a long while now, we should remove it.

@domenkozar
Copy link
Member

domenkozar commented Jun 14, 2017

  1. Remove usage in nixpkgs

Scope:

$ git grep "types\.string;" | wc -l
205
  1. Use builtins.trace to deprecate it.
  2. Remove in next NixOS release

@Profpatsch
Copy link
Member Author

Profpatsch commented Jun 17, 2017

$ git grep "types.string;" | wc -l
205

Oh, that’s interesting. My ag search turned up no usage, but maybe I did it wrong.

@pingiun
Copy link
Member

pingiun commented Oct 24, 2019

  1. and 2. have been done in 03391cd (Properly deprecate types.string #66346)

Checking right now in master gives 0 usages. The deprecation text does not say that the type will be removed in the next NixOS release, should that be added?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@Profpatsch
Copy link
Member Author

I’ll take a look.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@infinisil infinisil added the 6.topic: module system About "NixOS" module system internals label Sep 4, 2020
@stale
Copy link

stale bot commented Mar 5, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 5, 2021
@RyzeNGrind
Copy link

Hi any updates on removing the types.string deprecation error? I am just now getting into Nix and NIxOS ecosystem and I cannot rebuild my configuration due to multiple module/nixpkg references coming from this deprecated type error. Kindly advise.

[nixos@shogun:/mnt/c/Users/$USER/WSL]$ sudo nixos-rebuild switch --flake /etc/nixos#
building the system configuration...
error: The type `types.string` is deprecated. See https://github.com/NixOS/nixpkgs/pull/66346 for better alternative types.
(use '--show-trace' to show detailed location information)

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 11, 2023
@pf56
Copy link

pf56 commented Aug 13, 2023

@RyzeNGrind I just ran into the same issue. In my case, I was unknowingly mixing nixos-unstable with the home-manager 23.05 release branch. Switching to home-managers master branch fixed it for me.

In any case, you can run nixos-rebuild with --show-trace (and possibly --option eval-cache false) to get an idea of what package is causing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 6.topic: module system About "NixOS" module system internals 9.needs: clean-up
Projects
None yet
Development

No branches or pull requests

7 participants