Skip to content

Commit

Permalink
monero-cli: update submodule version; disable aarch64-darwin
Browse files Browse the repository at this point in the history
`trezor-common` submodule updated to match the rev at the version tag,
as per the conversation here:
#341980 (comment)

Mark as disabled on macOS/ARM because it does not build.

Formatted with `nixfmt-rfc-style`.

Tested on macOS M1 both via `nix-build -A monero-cli` and via
`nixpkgs-review`.
  • Loading branch information
philipmw committed Oct 9, 2024
1 parent 97b33aa commit c2ec210
Showing 1 changed file with 20 additions and 7 deletions.
27 changes: 20 additions & 7 deletions pkgs/applications/blockchains/monero-cli/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
}:

let
# submodules
# submodules; revs are taken from monero repo's `/external` at the given monero version tag.
supercop = fetchFromGitHub {
owner = "monero-project";
repo = "supercop";
Expand All @@ -37,12 +37,11 @@ let
trezor-common = fetchFromGitHub {
owner = "trezor";
repo = "trezor-common";
rev = "bc28c316d05bf1e9ebfe3d7df1ab25831d98d168";
hash = "sha256-F1Hf1WwHqXMd/5OWrdkpomszACTozDuC7DQXW3p6248=";
rev = "bff7fdfe436c727982cc553bdfb29a9021b423b0";
hash = "sha256-VNypeEz9AV0ts8X3vINwYMOgO8VpNmyUPC4iY3OOuZI=";
};

in

stdenv.mkDerivation rec {
pname = "monero-cli";
version = "0.18.3.4";
Expand Down Expand Up @@ -111,14 +110,28 @@ stdenv.mkDerivation rec {
"-DCMAKE_CXX_FLAGS=-fpermissive"
];

outputs = [ "out" "source" ];
outputs = [
"out"
"source"
];

meta = {
description = "Private, secure, untraceable currency";
homepage = "https://getmonero.org/";
license = lib.licenses.bsd3;
platforms = lib.platforms.all;
maintainers = with lib.maintainers; [ rnhmjoj ];

platforms = with lib.platforms; linux;

# macOS/ARM has a working `monerod` (at least), but `monero-wallet-cli`
# segfaults on start after entering the wallet password, when built in release mode.
# Building the same revision in debug mode to root-cause the above problem doesn't work
# because of https://github.com/monero-project/monero/issues/9486
badPlatforms = [ "aarch64-darwin" ];

maintainers = with lib.maintainers; [
pmw
rnhmjoj
];
mainProgram = "monero-wallet-cli";
};
}

0 comments on commit c2ec210

Please sign in to comment.