Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make automatic suggestions immutable #457

Open
fricklerhandwerk opened this issue Dec 11, 2024 · 0 comments
Open

Make automatic suggestions immutable #457

fricklerhandwerk opened this issue Dec 11, 2024 · 0 comments
Labels
backend something the web server needs to provide the frontend with tech debt Activities that reduce tech debt

Comments

@fricklerhandwerk
Copy link
Collaborator

fricklerhandwerk commented Dec 11, 2024

Currently our implementation allows actually removing derivations from automatic suggestions. This destroys data which we will need in the future to improve suggestion quality.

As @RaitoBezarius originally proposed, instead let triaging workflows merely overlay a filter on derivations and maintainers. The activity log will also need to be adapted to track changes on the filter and display them accordingly. Then an issue draft will need to be a separate data model which can be written to, and then converted to a proper issue record when publishing.

In short, the metadata we add manually to an automatic suggestion is:

  • accepted or rejected?
  • derivations and channels affected (this says something about names and versions)
  • maintainers affected (this is not relevant for matching though)
@fricklerhandwerk fricklerhandwerk added the backend something the web server needs to provide the frontend with label Dec 11, 2024
@fricklerhandwerk fricklerhandwerk added the tech debt Activities that reduce tech debt label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend something the web server needs to provide the frontend with tech debt Activities that reduce tech debt
Projects
Status: No status
Development

No branches or pull requests

1 participant