Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging issues with dynamic state change for suggestions #397

Open
fricklerhandwerk opened this issue Nov 29, 2024 · 1 comment
Open

Paging issues with dynamic state change for suggestions #397

fricklerhandwerk opened this issue Nov 29, 2024 · 1 comment
Assignees
Labels
bug Something isn't working data something about quality or quantity of ingested data skin Anything related to the visual presentation

Comments

@fricklerhandwerk
Copy link
Collaborator

Switching to the next page after dismissing suggestions with JS enabled will skip items in the previous page.

Reproducer

  1. Load first page in suggestion view
  • Open second page in new tab, take note what's the first item
  1. select/dismiss a few items
  2. Switch to second page

The first item on the second page will be different than what it was previously. As a result, users will miss what has shifted to the front.

With dynamic loading it's now more involved to reason about paging, and we'll have to come up with a pattern that scales and allows for both good UX with JS enabled but also degrades nicely with acceptable performance.

@fricklerhandwerk fricklerhandwerk added bug Something isn't working data something about quality or quantity of ingested data skin Anything related to the visual presentation labels Nov 29, 2024
@fricklerhandwerk fricklerhandwerk added this to the 3 Security team demo milestone Nov 29, 2024
@fricklerhandwerk fricklerhandwerk moved this to Needs refinement in Nixpkgs Security Scanner Nov 29, 2024
@fricklerhandwerk
Copy link
Collaborator Author

Since we can do arbitrary dynamic stuff in this realm, how about we trigger shifting an element in from the next page once we remove one on the current (and vice versa)? This has the additional advantage of being much more performance tolerant, so we have time to reshuffle the paging in the background.

@fricklerhandwerk fricklerhandwerk moved this from Needs refinement to Ready in Nixpkgs Security Scanner Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data something about quality or quantity of ingested data skin Anything related to the visual presentation
Projects
Status: Ready
Development

No branches or pull requests

2 participants