Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security page of a certain Nix issue #10

Closed
5 tasks done
RaitoBezarius opened this issue Nov 5, 2023 · 6 comments
Closed
5 tasks done

Security page of a certain Nix issue #10

RaitoBezarius opened this issue Nov 5, 2023 · 6 comments
Assignees

Comments

@RaitoBezarius
Copy link
Collaborator

RaitoBezarius commented Nov 5, 2023

The security page of a certain Nix issue should:

  • be accessible via website.tld/$tracking
  • informs about the current status: awaiting-mitigation, mitigation-in-progress, mitigated, wontfix on each supported channel.
  • list all maintainers, grouped by package
  • list all known vulnerabilities
    • grouped by package

For maintainers (or more):

  • change status.
  • performs any operations: bump the package in that channel (unstable or stable X), add/remove a known vulnerability as a new PR.

For security team:

  • admin access.
@fricklerhandwerk
Copy link
Collaborator

We could use https://github.com/etianen/django-reversion for the activity log.

@RaitoBezarius
Copy link
Collaborator Author

That might be overkill because it will store the whole NixIssue information rather than just an activity log of "has changed X to Y", "has added X", etc.
But I guess that's an option.

@fricklerhandwerk
Copy link
Collaborator

fricklerhandwerk commented Dec 7, 2023

Django-reversion stores the versions of a model as JSON. If a model changes, the migrations are not applied to the stored JSON data. Therefore it can happen that an old version can no longer be restored.

-- common problems

Ew, okay. Nope.

There's also https://github.com/Opus10/django-pghistory, but that's bound to Postgres.

I generally like how https://github.com/jazzband/django-simple-history works, but one has to be extra careful to layout the data in a way that one doesn't store large rows on every little movement.

@RaitoBezarius
Copy link
Collaborator Author

RaitoBezarius commented Dec 8, 2023

We don't really care about being bound to PostgreSQL.

@alejandrosame
Copy link
Contributor

alejandrosame commented Dec 11, 2023

Check #101 for the activity log setup. As the commit message says, for now it tracks all changes to NixpkgsIssue model, but it's trivial to add per-field tracking once the model has stabilized.

@fricklerhandwerk
Copy link
Collaborator

Superseded by #1

@fricklerhandwerk fricklerhandwerk closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants