Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow recording an overridden severity level for an advisory #51

Closed
raboof opened this issue Nov 23, 2023 · 3 comments
Closed

Allow recording an overridden severity level for an advisory #51

raboof opened this issue Nov 23, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@raboof
Copy link
Collaborator

raboof commented Nov 23, 2023

As encountered in the example of #22, there might be situations where we disagree with the severity rating provided with an advisory (in this case: the CVSS score of MEDIUM). As CVSS can be restrictive in how it assigns severity ratings, we might want to introduce a text-based severity rating of our own (like low/moderate/important/critical).

For the API, it would be sufficient to encode this as simple advisory id, severity pairs, as in the vast majority of cases an advisory will have the same severity regardless of the version of the affected package. This keeps the data volume of the information to be shared low.

An example would be: CVE-2023-38253 low.

Since this can be so compact the online tracker could provide all this data as a single bulk endpoint, so instead of having to do many requests the local tool can just get all overridden severities in a single request and cache that knowledge.

@fricklerhandwerk
Copy link
Contributor

fricklerhandwerk commented Dec 11, 2023

Discussed with @raboof

Request:

GET /api/v1/issues/by_cve?cve=CVE-1234-12345&cve=CVE-1234-12346

Note

URL length is 8KB by default. GET bodies are non-standard. POST doesn't seem right.

Response returns all issues that have status other than UNKNOWN:

[
  {
    "id": "NIXPKGS-1234-12345",
    "cve": [ "CVE-1234-12345", "CVE-4321-54321" ],
    "status": "WONTFIX",
  },
  {
    "id": "NIXPKGS-1234-12346",
    "cve": [ "CVE-1234-12346", "CVE-4321-54328" ],
    "status": "WONTFIX",
  }
]

@fricklerhandwerk
Copy link
Contributor

@raboof
Copy link
Collaborator Author

raboof commented Dec 13, 2023

Implemented in the local scanner in Nix-Security-WG/nix-security-tracker#125 🎉

@raboof raboof closed this as completed Dec 13, 2023
@fricklerhandwerk fricklerhandwerk transferred this issue from Nix-Security-WG/nix-security-tracker Sep 23, 2024
@fricklerhandwerk fricklerhandwerk transferred this issue from Nix-Security-WG/nix-local-security-scanner Sep 23, 2024
@fricklerhandwerk fricklerhandwerk transferred this issue from Nix-Security-WG/nix-security-tracker Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants