Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat #74 : Create a Story Component #86

Merged
merged 8 commits into from
May 26, 2024
Merged

Feat #74 : Create a Story Component #86

merged 8 commits into from
May 26, 2024

Conversation

CoderSwarup
Copy link
Contributor

Fixes Issue

close #74

Changes proposed

create a Story Ui component similar to the instagram story feed section where user others user story. Here's a sample video demonstrating the UI: video.

Screenshots

storyui

storyui2

Note to reviewers

Here's the frontend work I've completed. If you'd like to implement the backend (using Appwrite) to fetch real user data for the stories and display it, please let me know.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, CoderSwarup, for creating this pull request and contributing to OpenGrame! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@Nishitbaria Nishitbaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CoderSwarup We are only using Shadcn and tailwind CSS please don't use Normal Css please convert this Tailwindcss

Second Point

image

Check the Figma file its not look same as file contain please follow same typography as Figma file contain and this story not be a static its should be Dynamic

image

User must be able to upload Story

@CoderSwarup
Copy link
Contributor Author

Hey @CoderSwarup We are only using Shadcn and tailwind CSS please don't use Normal Css please convert this Tailwindcss

Second Point

image

Check the Figma file its not look same as file contain please follow same typography as Figma file contain and this story not be a static its should be Dynamic

image

User must be able to upload Story

ok

one query that i use my own appwrite or you can provide the your appwrite access to me

@Nishitbaria
Copy link
Owner

Hey @CoderSwarup We are only using Shadcn and tailwind CSS please don't use Normal Css please convert this Tailwindcss
Second Point
image
Check the Figma file its not look same as file contain please follow same typography as Figma file contain and this story not be a static its should be Dynamic
image
User must be able to upload Story

ok

one query that i use my own appwrite or you can provide the your appwrite access to me

for now I will provide you my dummy appwrite account :

use this as id and pass : [email protected]

@CoderSwarup
Copy link
Contributor Author

CoderSwarup commented May 16, 2024

Hey @CoderSwarup We are only using Shadcn and tailwind CSS please don't use Normal Css please convert this Tailwindcss
Second Point
image
Check the Figma file its not look same as file contain please follow same typography as Figma file contain and this story not be a static its should be Dynamic
image
User must be able to upload Story

ok
one query that i use my own appwrite or you can provide the your appwrite access to me

for now I will provide you my dummy appwrite account :

use this as id and pass : [email protected]

image

please check the ui

and what is the appwrite password

@Nishitbaria
Copy link
Owner

Hey @CoderSwarup We are only using Shadcn and tailwind CSS please don't use Normal Css please convert this Tailwindcss
Second Point
image
Check the Figma file its not look same as file contain please follow same typography as Figma file contain and this story not be a static its should be Dynamic
image
User must be able to upload Story

ok
one query that i use my own appwrite or you can provide the your appwrite access to me

for now I will provide you my dummy appwrite account :
use this as id and pass : [email protected]

image

please check the ui

Just change button color other vice other things LGTM

@CoderSwarup
Copy link
Contributor Author

CoderSwarup commented May 16, 2024

Hey @CoderSwarup We are only using Shadcn and tailwind CSS please don't use Normal Css please convert this Tailwindcss
Second Point
image
Check the Figma file its not look same as file contain please follow same typography as Figma file contain and this story not be a static its should be Dynamic
image
User must be able to upload Story

ok
one query that i use my own appwrite or you can provide the your appwrite access to me

for now I will provide you my dummy appwrite account :
use this as id and pass : [email protected]

image
please check the ui

Just change button color other vice other things LGTM

image

check now

image

and any changes required here in story view Model

@Nishitbaria
Copy link
Owner

Hey @CoderSwarup We are only using Shadcn and tailwind CSS please don't use Normal Css please convert this Tailwindcss
Second Point
image
Check the Figma file its not look same as file contain please follow same typography as Figma file contain and this story not be a static its should be Dynamic
image
User must be able to upload Story

ok
one query that i use my own appwrite or you can provide the your appwrite access to me

for now I will provide you my dummy appwrite account :
use this as id and pass : [email protected]

image
please check the ui

Just change button color other vice other things LGTM

image

check now

image

and any changes required here in the story view Model

Don't make it Transparent make the background blurry

@CoderSwarup
Copy link
Contributor Author

use this as id and pass : [email protected]

ok
please give me the password of the appwrite

@Nishitbaria
Copy link
Owner

use this as id and pass : [email protected]

ok
please give me the password of the appwrite

This email is both email and password

@Atharva1723
Copy link
Contributor

Hey @CoderSwarup We are only using Shadcn and tailwind CSS please don't use Normal Css please convert this Tailwindcss
Second Point
image
Check the Figma file its not look same as file contain please follow same typography as Figma file contain and this story not be a static its should be Dynamic
image
User must be able to upload Story

ok
one query that i use my own appwrite or you can provide the your appwrite access to me

for now I will provide you my dummy appwrite account :
use this as id and pass : [email protected]

image
please check the ui

Just change button color other vice other things LGTM

image
check now
image
and any changes required here in the story view Model

Don't make it Transparent make the background blurry

Similar when we press logout the background , its currently transparent it should be blurry !

@CoderSwarup
Copy link
Contributor Author

@Nishitbaria please check the changes

@Nishitbaria
Copy link
Owner

@Nishitbaria please check the changes

please fix the conflicts

@CoderSwarup
Copy link
Contributor Author

@Nishitbaria conflicts Resolve sample video link here

Before trying the please change the VITE_APPWRITE_STORIES_DATA_COLLECTION_ID="664701060006ef1071bf" add this env with main appwrite with attribute

image

@Nishitbaria
Copy link
Owner

@Nishitbaria conflicts Resolve sample video link here

Before trying the please change the VITE_APPWRITE_STORIES_DATA_COLLECTION_ID="664701060006ef1071bf" add this env with main appwrite with attribute

image

Can you please provide me appwrite.json

@CoderSwarup
Copy link
Contributor Author

CoderSwarup commented May 19, 2024

@Nishitbaria conflicts Resolve sample video link here
Before trying the please change the VITE_APPWRITE_STORIES_DATA_COLLECTION_ID="664701060006ef1071bf" add this env with main appwrite with attribute
image

Can you please provide me appwrite.json

I use your give credentials for login [email protected] you can directly access this

appwrite.json

@CoderSwarup
Copy link
Contributor Author

@Nishitbaria any update

@Nishitbaria
Copy link
Owner

@Nishitbaria any update

I check one thing is that it's not align with. Current db I have config for that

@CoderSwarup
Copy link
Contributor Author

@Nishitbaria any update

I check one thing is that it's not align with. Current db I have config for that

ok
which config file you need

if you need appwrite.json file
so please help me to generate the appwrite config file how i can do that

already available config file is
appwrite.json

@Nishitbaria
Copy link
Owner

@Nishitbaria any update

I check one thing is that it's not align with. Current db I have config for that

ok which config file you need

if you need appwrite.json file so please help me to generate the appwrite config file how i can do that

already available config file is appwrite.json

Just wait for more 1 day I will try to solve that all issue tomorrow is my last paper

@Nishitbaria
Copy link
Owner

Hey @CoderSwarup I have added new project on appwrite add your stories Schema on User Schema Look at on appwrite

@CoderSwarup
Copy link
Contributor Author

CoderSwarup commented May 21, 2024

Hey @CoderSwarup I have added new project on appwrite add your stories Schema on User Schema Look at on appwrite

Check the project i added story schema

@Nishitbaria
Copy link
Owner

Hey @CoderSwarup I have added new project on appwrite add your stories Schema on User Schema Look at on appwrite

Check the project i added story schema

when User Create Post then there is ref of the post in Both Post and User Schema There is between relationship i didn't find that you make any kind of relationship its require to store the reference that who added the stories :

image

@Nishitbaria
Copy link
Owner

Hey @CoderSwarup Stories is upload and second think i want to say that did you implemented that logic that after 24hour storis is automatically removed ?

Refactor stories.svg to update the fill color to #877EFF. This change improves the visual consistency of the icon.

Refactor LeftSidebar component to remove unused imports and useEffect dependencies. This improves the readability and performance of the component.

Related recent commits:
- chore: Refactor Home and StoriesContainer components for improved readability and performance
- chore: Refactor Home component for improved readability and performance
- chore: Update appwriteConfig to use correct stories collection ID
- fix: some Ui Part of code
- Merge branch 'main' into storyui
- Merge pull request #109 from Unalia09/main
- Update SigninForm.tsx
- Corrected the grammatical error
- Merge pull request #91 from sambitsingha/main
- [Feature] - Custom 404 Not Found page added
- Added a timer functionality which will redirect the user back to the home page, after seeing the 404 page
- Merge branch 'Nishitbaria:main' into main
@Nishitbaria
Copy link
Owner

@CoderSwarup Everythings Looks Good But I found Two bugs

  1. When as User i first time added Stories its visible to everyone
  2. but when i try to upload Stories then its uploaded but not visible for other as well for me

@CoderSwarup
Copy link
Contributor Author

@CoderSwarup Everythings Looks Good But I found Two bugs

  1. When as User i first time added Stories its visible to everyone
  2. but when i try to upload Stories then its uploaded but not visible for other as well for me

bug : When you upload the second story in story feed section you and other user see the old story means 1st , it's write or the 2nd story complete not visible?

@Nishitbaria
Copy link
Owner

@CoderSwarup Everythings Looks Good But I found Two bugs

  1. When as User i first time added Stories its visible to everyone
  2. but when i try to upload Stories then its uploaded but not visible for other as well for me

bug : When you upload the second story in story feed section you and other user see the old story means 1st , it's write or the 2nd story complete not visible?

Yea When i login with second account then its show first account stories but when i upload with second account stories then its uploaded but not visible on my profile as well for other profile too @CoderSwarup

@CoderSwarup
Copy link
Contributor Author

CoderSwarup commented May 26, 2024

second account then its show first account stories but when i upload with second account stories then its uploaded but not v

you need to reload the page of the user its because of the we not use the real time connection

@CoderSwarup
Copy link
Contributor Author

CoderSwarup commented May 26, 2024

@Nishitbaria

User 1 Story Visible on user 2 Account
image

User 1 Upload Story

image

User 1 Story Uploaded Successfully
image

On user 2 Story Shows the old Data on user 2 before reload
image

After reload On user 2
image

@Nishitbaria
Copy link
Owner

@CoderSwarup See
Uploading OpenGrame and 1 more page - Personal - Microsoft​ Edge 2024-05-26 11-58-13.mp4…

@CoderSwarup
Copy link
Contributor Author

@CoderSwarup See Uploading OpenGrame and 1 more page - Personal - Microsoft​ Edge 2024-05-26 11-58-13.mp4…

video is not upload

@Nishitbaria
Copy link
Owner

@CoderSwarup See Uploading OpenGrame and 1 more page - Personal - Microsoft​ Edge 2024-05-26 11-58-13.mp4…

video is not upload

OpenGrame.and.1.more.page.-.Personal.-.Microsoft.Edge.2024-05-26.11-58-13.mp4

@CoderSwarup
Copy link
Contributor Author

ok bug is when you upload your story then it will be not showing itself

@Nishitbaria
Copy link
Owner

ok bug is when you upload your story then it will be not showing itself

Yes and also for other too

@CoderSwarup
Copy link
Contributor Author

Ok i will see that, can you send me your envs

@Nishitbaria
Copy link
Owner

Ok i will see that, can you send me your envs

VITE_APPWRITE_PROJECT_ID="664b72c700235fef3e76"
VITE_APPWRITE_URL="https://cloud.appwrite.io/v1"
VITE_APPWRITE_STORAGE_ID="65478ceca6d8a49b3cf1"
VITE_APPWRITE_DATABASE_ID="3j22cy28uc3"
VITE_APPWRITE_SAVES_COLLECTION_ID="65479a44782ab930d6f3"
VITE_APPWRITE_USERS_COLLECTION_ID="65479b3f3ff36d0c3fa6"
VITE_APPWRITE_POSTS_COLLECTION_ID="65479a1224b7d12ccb6e"
VITE_APPWRITE_STORIES_COLLECTION_ID="664c1dba0005c3bb2eae"

@CoderSwarup
Copy link
Contributor Author

CoderSwarup commented May 26, 2024

@Nishitbaria

Their is an error in you env

VITE_APPWRITE_PROJECT_ID="664b72c700235fef3e76"
VITE_APPWRITE_URL="https://cloud.appwrite.io/v1"
VITE_APPWRITE_STORAGE_ID="65478ceca6d8a49b3cf1"
VITE_APPWRITE_DATABASE_ID="3j22cy28uc3"
VITE_APPWRITE_SAVES_COLLECTION_ID="65479a44782ab930d6f3"
VITE_APPWRITE_USERS_COLLECTION_ID="65479b3f3ff36d0c3fa6"
VITE_APPWRITE_POSTS_COLLECTION_ID="65479a1224b7d12ccb6e"
VITE_APPWRITE_STORIES_DATA_COLLECTION_ID="664c1dba0005c3bb2eae"  

when i try its Work Perfectly also i see your Stories also

see the video

video

and also its work When i upload the New Story without reloading

image

its Take Time To Load the new Story Image

@Nishitbaria
Copy link
Owner

Nishitbaria commented May 26, 2024

@Nishitbaria

Their is an error in you env

VITE_APPWRITE_PROJECT_ID="664b72c700235fef3e76"
VITE_APPWRITE_URL="https://cloud.appwrite.io/v1"
VITE_APPWRITE_STORAGE_ID="65478ceca6d8a49b3cf1"
VITE_APPWRITE_DATABASE_ID="3j22cy28uc3"
VITE_APPWRITE_SAVES_COLLECTION_ID="65479a44782ab930d6f3"
VITE_APPWRITE_USERS_COLLECTION_ID="65479b3f3ff36d0c3fa6"
VITE_APPWRITE_POSTS_COLLECTION_ID="65479a1224b7d12ccb6e"
VITE_APPWRITE_STORIES_DATA_COLLECTION_ID="664c1dba0005c3bb2eae"  

when i try its Work Perfectly also i see your Stories also

see the video

video

and also its work When i upload the New Story without reloading

image

its Take Time To Load the new Story Image

I have just one last question did you implement the Automatic Remove Stories feature?
if not then create new issue and working on that

@Nishitbaria Nishitbaria merged commit 9bc09dd into Nishitbaria:main May 26, 2024
6 checks passed
@Nishitbaria Nishitbaria added enhancement New feature or request gssoc Girl Script Summer of Code level3 Making completely new feature goal: new-feature New feature or request development Still being developed discussion For taking issues into discussion board and removed Request: Changes labels May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Still being developed discussion For taking issues into discussion board enhancement New feature or request goal: new-feature New feature or request gssoc Girl Script Summer of Code level3 Making completely new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implementing Story UI on Home page
3 participants