Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleLogin is added issue #37 #55

Closed
wants to merge 1 commit into from

Conversation

DhruvPandey1
Copy link

Google login feature has been added to this project

issue is fixed #37

Added a Google login feature in this project. So we can know also login with our Goggle account
I'll add some screenshot of the login

Screenshots

s1
s2

Note to reviewers

Note that I added the feature U just need to create a project on google console with Oauth option As a web application and take the clientId and client secret and go to ur appwrite project auth setting and enable google login and provide the clientid and client secret to it . I can't do that because I don't have access to the original project so just this steps u have to follow and google feature will be one point.

Now Kindly merge this PR under GSSOC'24 level3

Google login feature has been added to this project
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, DhruvPandey1, for creating this pull request and contributing to OpenGrame! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Nishitbaria
Copy link
Owner

Google login feature has been added to this project

issue is fixed #37

Added a Google login feature in this project. So we can know also login with our Goggle account I'll add some screenshot of the login

Screenshots

s1 s2

Note to reviewers

Note that I added the feature U just need to create a project on google console with Oauth option As a web application and take the clientId and client secret and go to ur appwrite project auth setting and enable google login and provide the clientid and client secret to it . I can't do that because I don't have access to the original project so just this steps u have to follow and google feature will be one point.

Now Kindly merge this PR under GSSOC'24 level3

Hey @DhruvPandey1 I am not able to sign in Using Google can you provide me the client id and client secret so i can test the app from my side

or just add video

@DhruvPandey1
Copy link
Author

Hey @Nishitbaria ! U need toprovide ur clientID and Secret because u are the main authority from making google console project otherwise all auth detail come on my console throuth that Id

@Nishitbaria
Copy link
Owner

Hey @Nishitbaria ! U need toprovide ur clientID and Secret because u are the main authority from making google console project otherwise all auth detail come on my console throuth that Id

Yes I know I added my credential but in that case its also not work That why i tell you too show me a video

@Nishitbaria
Copy link
Owner

@DhruvPandey1 When User is Created then logically user must be created but in this case user is not created

@DhruvPandey1
Copy link
Author

@Nishitbaria ! I will change this code there is a slight error after creating user and form another PR sorry inconvenience

Copy link
Owner

@Nishitbaria Nishitbaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DhruvPandey1 Change with the original website url here you added localhost remove it

@Nishitbaria
Copy link
Owner

Its is not working so I am Closing PR @DhruvPandey1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Signup and Login with Google using Appwrite
2 participants